Merge lp:~canonical-platform-qa/autopilot-gtk/fix-failing-mouse-test_1483815 into lp:autopilot-gtk

[Christopher Lee]

Fix test; Add wait so dialog button is clickable

Update sporadically failing test.

Reason for the failure was that the attempt to click the dismiss button was happening before the dialog was fully displayed (and thus able to be clicked).

Using a sleep as I couldn't find any other property status that would indicate that the dialog is fully shown and thus the button could be pressed.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:77
http://jenkins.qa.ubuntu.com/job/autopilot-gtk-ci/80/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-gtk-wily-amd64-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-gtk-wily-armhf-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-gtk-wily-i386-ci/1/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-gtk-ci/80/rebuild

review: Needs Fixing (continuous-integration)

[Iain Lane (laney)]

I was just looking at the same test failure. For me this didn't fix it. It seem{s,ed} that the problem is that we need to wait a bit after clicking the button for the dialog to be destroyed, in the mouse case. If we had Eventually(raises(... support then this would work, but we don't so need to test the same thing in a roundabout way. Filed

  https://code.launchpad.net/~laney/autopilot-gtk/tests-wait-not-visible/+merge/268928

to hopefully fix this.

review: Disapprove

Unmerged revisions

77. By Christopher Lee on 2015-08-24

Fix test; Add wait so dialog button is clickable

=== modified file 'tests/autopilot/tests/test_actions.py'
--- tests/autopilot/tests/test_actions.py	2013-12-18 10:48:35 +0000
+++ tests/autopilot/tests/test_actions.py	2015-08-24 04:02:53 +0000
@@ -16,6 +16,7 @@
 
 import os.path
 import os
+import time
 
 from autopilot.testcase import AutopilotTestCase
 from autopilot.introspection.dbus import StateNotFoundError
@@ -122,6 +123,9 @@
 
         # close the dialog
         btn = md.select_single('GtkButton')
+        # Give the dialog time to show so the button is clickable, unable to
+        # find a property the query for this.
+        time.sleep(0.5)
         self.mouse.click_object(btn)
         self.assertThat(
             lambda: self.app.select_single('GtkMessageDialog', visible=True),