Merge auto-upgrade-testing-specifications:ubuntu-unity-move-from-task-to-metapackage into auto-upgrade-testing-specifications:main

Proposed by Tim Andersson
Status: Merged
Approved by: Brian Murray
Approved revision: d2a19951ddbe0dc6518bee0b99e6b6993c9c6fa7
Merged at revision: d2a19951ddbe0dc6518bee0b99e6b6993c9c6fa7
Proposed branch: auto-upgrade-testing-specifications:ubuntu-unity-move-from-task-to-metapackage
Merge into: auto-upgrade-testing-specifications:main
Diff against target: 13 lines (+1/-1)
1 file modified
profiles/ubuntu-lunar-mantic-ubuntu-unity-amd64_qemu.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Paride Legovini Approve
Review via email: mp+451985@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

Thanks for the detailed commit message and bug reference!

Revision history for this message
Paride Legovini (paride) wrote :

LGTM, however it's not clear to be whether the "right" way to install flavors is the task or the metapackage. If the "right" way is using the task, then I think we should keep it. @Brian do you happen to know better?

review: Needs Information
Revision history for this message
Tim Andersson (andersson123) wrote :

ubuntucinnamon already doesn't use the task. Not sure if that's helpful

Revision history for this message
Paride Legovini (paride) wrote :

Posthumous approve (this is merged already) after reading [1].

[1] https://bugs.launchpad.net/ubuntu/+source/ubuntu-unity-meta/+bug/2036989/comments/2

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/profiles/ubuntu-lunar-mantic-ubuntu-unity-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-ubuntu-unity-amd64_qemu.yaml
2index 1d7c351..e186456 100644
3--- a/profiles/ubuntu-lunar-mantic-ubuntu-unity-amd64_qemu.yaml
4+++ b/profiles/ubuntu-lunar-mantic-ubuntu-unity-amd64_qemu.yaml
5@@ -6,7 +6,7 @@
6 flavor: ubuntu-unity
7 image_name: lunar_mantic_ubuntu_unity_desktop_amd64.img
8 build_args:
9- - "--post-command 'sudo apt-get -y update && sudo apt-get -y dist-upgrade && sudo DEBIAN_FRONTEND=noninteractive apt-get -y install ubuntu-unity-desktop^' -v --timeout 14400"
10+ - "--post-command 'sudo apt-get -y update && sudo apt-get -y dist-upgrade && sudo DEBIAN_FRONTEND=noninteractive apt-get -y install ubuntu-unity-desktop' -v --timeout 14400"
11 releases:
12 - "lunar"
13 - "mantic"

Subscribers

No one subscribed via source and target branches