Merge lp:~canonical-platform-qa/address-book-app/fix_base_class into lp:address-book-app

[Leo Arias]

Fix the base class used when launching the app in autopilot tests.

Using the common base class from the toolkit simplifies the inheritance of autopilot custom proxy objects. The tests are the same, but this allows us to make some changes on the autopilot registry.

Are there any related MPs required for this MP to build/function as expected? Please list.

No related MPs.

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

It is.

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

Just running the tests.

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?

Just the automated ones. There is an unrelated error in one of the tests.

If you changed the UI, was the change specified/approved by design?

No UI changes.

If you changed UI labels, did you update the pot file?

No label changes.

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

No packaging changes.

[Christopher Lee (veebers)]

LGTM

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:423
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/793/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/96
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2230
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/803/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1956
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2228
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2228/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19623
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/643/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/962
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/962/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/793/rebuild

review: Needs Fixing (continuous-integration)

[Leo Arias (elopio)]

getting a new execution to see if the network errors in jenkins are solved.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:423
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/794/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/97
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2250
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/805/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1975
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2248
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2248/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19654
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/645/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/964
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/964/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/794/rebuild

review: Needs Fixing (continuous-integration)

[Renato Araujo Oliveira Filho (renatofilho)]

Do we still need the implementation of "AddressBookApp" class? If not we should remove the code from __init__.py file.

review: Needs Information

[Leo Arias (elopio)]

Yes, it is needed. Autopilot will keep it in the object registry, so every time a QML object matches the validate_dbus method of AddressBookApp, autopilot will instantiate it and return our custom proxy object instead of a generic one.

[Renato Araujo Oliveira Filho (renatofilho)]

ok thanks for the information.

review: Approve

=== modified file 'tests/autopilot/address_book_app/tests/__init__.py'
--- tests/autopilot/address_book_app/tests/__init__.py	2015-02-19 07:02:09 +0000
+++ tests/autopilot/address_book_app/tests/__init__.py	2015-04-14 22:19:45 +0000
@@ -25,7 +25,7 @@
 from autopilot.platform import model
 from testtools.matchers import Equals
 
-import address_book_app
+import ubuntuuitoolkit
 from ubuntuuitoolkit import emulators as toolkit_emulators
 
 
@@ -98,7 +98,7 @@
             self.app_bin,
             *AddressBookAppTestCase.ARGS,
             app_type='qt',
-            emulator_base=address_book_app.AddressBookApp)
+            emulator_base=ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase)
 
     def launch_test_installed(self):
         df = "/usr/share/applications/address-book-app.desktop"
@@ -107,12 +107,12 @@
             "address-book-app",
             *AddressBookAppTestCase.ARGS,
             app_type='qt',
-            emulator_base=address_book_app.AddressBookApp)
+            emulator_base=ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase)
 
     def launch_click_installed(self):
         return self.launch_click_package(
             'com.ubuntu.address-book',
-            emulator_base=address_book_app.AddressBookApp)
+            emulator_base=ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase)
 
     @property
     def main_window(self):