launchpad:master

Last commit made on 2019-11-26
Get this branch:
git clone -b master https://git.launchpad.net/launchpad
Members of Canonical Launchpad Branches can upload to this branch. Log in for directions.

Branch merges

Branch information

Name:
master
Repository:
lp:launchpad

Recent commits

956340c... by Colin Watson on 2019-11-26

Fix handling of packagename_option on DSP:+filebug

If "In what package did you find this bug?" is set to "I don't know" on
DistributionSourcePackage:+filebug, then it's most coherent to treat
that as if the bug had been filed using the corresponding
Distribution:+filebug.

LP: #1847647

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/374086

64053e2... by Colin Watson on 2019-11-22

Upgrade to zope.testbrowser 5.5.1

zope.testbrowser 5.0.0 switched its internal implementation to WebTest
instead of mechanize. This necessitates several changes in Launchpad.
In some cases the new default behaviours are already appropriate (for
example, `<meta http-equiv="refresh" />` tags are no longer followed),
and in some we just need to poke into the implementation in slightly
different ways.

We have to patch around a few bugs, although fortunately this can all be
contained in lp.testing.pages:

 * WebTest doesn't understand `<input type="search" />`
   (https://github.com/Pylons/webtest/pull/219, awaiting an upstream
   release).

 * `Browser.reload` reuses the existing request rather than making a new
   one (related to
   https://github.com/zopefoundation/zope.testbrowser/issues/74).

 * zope.testbrowser doesn't support finding links by image alt text.

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/375427

55df87c... by Ioana Lasc on 2019-11-22

GitRepositoryCreatorNotOwner exception was surfacing with a 500 http code instead of 400 because of non ASCII character in the name of the user 'devnull' used to invoke remote build.

Merged from https://code.launchpad.net/~ilasc/launchpad/+git/launchpad/+merge/375614

a290acd... by Ioana Lasc on 2019-11-22

Fixed order of imports in errors.py.

e45c05c... by Ioana Lasc on 2019-11-22

Moved to python 3 compatible strings for GitRepositoryCreatorNotMemberOfOwnerTeam and GitRepositoryCreatorNotOwner.

a42912a... by Colin Watson on 2019-11-20

Capture OOPSes in doctests

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/375762

59d9970... by Colin Watson on 2019-11-18

Capture OOPSes in doctests

TestCase has captured OOPSes in Launchpad's unit tests since 2010, but
we've never systematically done the same thing for doctests. This
occasionally causes some problems: with amqp >= 2.4.0 it can mean that
attempts to publish OOPSes to a nonexistent exchange leave unhandled
errors lying around to trip up later tests (see
https://code.launchpad.net/~cjwatson/python-oops-amqp/publisher-handle-channel-errors/+merge/367748),
which is extremely confusing and difficult to debug, and I suspect has
caused a number of transient failures on buildbot.

We now systematically capture OOPSes for doctests just as we do for unit
tests, ensuring better test isolation. I cleaned up a few ad-hoc
arrangements in individual doctests.

f305f14... by Ioana Lasc on 2019-11-20

Cleanup after running make lint.

ab2e14b... by Ioana Lasc on 2019-11-20

Added better name for new test method on Webservice.

fb18557... by Ioana Lasc on 2019-11-20

Removed test method test_Anew_not_owner from TestGitRepositorySet - used only for debug / experimentation purposes.