We now have a stable cnl on our CI and it seems mostly
green without big risks of blank screen or anything
blowing up on linux installations in the future.
As a reminder i915.alpha_support was created to protect
future linux installation's iso images that might contain a
kernel from the enabling time of the new platform. Without this
protection most of linux installation was recommending
nomodeset option during installation that was getting stick
there after installation.
Specifically, alpha support says nothing about the development
state of the hardware, and everything about the state of the
driver in a kernel release.
This is semantically no different from the old
preliminary_hw_support flag, but the old one was all too often
interpreted as (preliminary hw) support instead of the intended
(preliminary) hw support, and it was misleading for everyone.
Hence the rename.
v2: Fix the typos and include more history about the parameter
rename on commit message. (Jani)
Reference: https://intel-gfx-ci.01.org/tree/drm-tip/fi-cnl-y3.html
Cc: James Ausmus <email address hidden>
Cc: Lucas De Marchi <email address hidden>
Cc: Jani Saarinen <email address hidden>
Cc: Jani Nikula <email address hidden>
Cc: Joonas Lahtinen <email address hidden>
Signed-off-by: Rodrigo Vivi <email address hidden>
Acked-by: Jani Nikula <email address hidden>
Link: https://patchwork<email address hidden>
(cherry picked from git://anongit.freedesktop.org/drm/drm-intel commit ccf74400da4d7c94307ac24e7398337d9c4312d9)
Signed-off-by: Timo Aaltonen <email address hidden>
Register Address for CNL_PORT_DW5_LN0_D is 0x162E54, but current code is
defining it as 0x162ED4. Similarly for CNL_PORT_DW7_LN0_D register address
is defined 0x162EDC instead of 0x162E5C, fix it.
Signed-off-by: Mahesh Kumar <email address hidden>
Fixes: 04416108ccea ("drm/i915/cnl: Add registers related to voltage swing sequences.")
Reviewed-by: Rodrigo Vivi <email address hidden>
Signed-off-by: Rodrigo Vivi <email address hidden>
Link: https://patchwork<email address hidden>
(cherry picked from git://anongit.freedesktop.org/drm/drm-intel commit e103962611b2d464be6ab596d7b3495fe7b4c132)
Signed-off-by: Timo Aaltonen <email address hidden>
Add one missing PCI ID and sort them in a way
that gets easier to review and compare against spec's
table.
When trying to sync libdrm and mesa id list with kernel
and spec I noticed something was wrong and we were missing
a pci id. So to make our lives easier when checking against
spec let's simplify and sort like spec does.
BSpec: 13621
Cc: Lucas De Marchi <email address hidden>
Cc: James Ausmus <email address hidden>
Signed-off-by: Rodrigo Vivi <email address hidden>
Reviewed-by: James Ausmus <email address hidden>
Link: https://patchwork<email address hidden>
(cherry picked from git://anongit.freedesktop.org/drm/drm-intel commit e3890d05b34266f5981876c65a6a97fc0d0d0ccb)
Signed-off-by: Timo Aaltonen <email address hidden>
891dad3...
by
Rafael Antognolli <email address hidden>
This workaround should prevent a bug that can be hit on a context
restore. To avoid the issue, we must emit a PIPE_CONTROL with CS stall
(0x7a000004 0x00100000 0x00000000 0x00000000) followed by 12DW's of
NOOP(0x0) in the indirect context batch buffer, to ensure the engine is
idle prior to programming 3DSTATE_SAMPLE_PATTERN.
It's also not clear whether we should add those extra dwords because of
the workaround itself, or if that's just padding for the WA BB (and next
commands could come right after the PIPE_CONTROL). We keep them for now.
References: HSD#1939868
v2: More descriptive changelog and comments.
v3: Explain that PIPE_CONTROL is actually 6 dwords, and that we advance
10 more dwords because of that.
Signed-off-by: Rafael Antognolli <email address hidden>
Cc: Chris Wilson <email address hidden>
Acked-by: Chris Wilson <email address hidden>
Signed-off-by: Chris Wilson <email address hidden>
Link: https://patchwork.freedesktop<email address hidden>
(cherry picked from git://anongit.freedesktop.org/drm/drm-intel commit 4b6ce6810a5dc0af387a238e8c852e0d3822381f)
Signed-off-by: Timo Aaltonen <email address hidden>
We have the max DP link rate info available in VBT since BDB version
216, included in child device config since commit c4fb60b9aba9
("drm/i915/bios: add DP max link rate to VBT child device
struct"). Parse it and use it.
On CNL SKUs that uses port F, max DP rate is 8.1G for all
ports when we have the elevated voltage (higher than 0.85V).
v2: Make commit message more generic.
v3: Move conditions to a helper to get easier to read. (Ville).
v4: Add a mention to the numerical voltage on commit
message per Manasi request.
v5: Thanks CI! "error: control reaches end of non-void function"
Cc: Ville Syrjälä <email address hidden>
Cc: Lucas De Marchi <email address hidden>
Cc: Manasi Navare <email address hidden>
Signed-off-by: Rodrigo Vivi <email address hidden>
Reviewed-by: Manasi Navare <email address hidden>
Link: https://patchwork<email address hidden>
(backported from git://anongit.freedesktop.org/drm/drm-intel commit 53ddb3cdb063d7be74aa22ed831cad8aa5ee0863)
Signed-off-by: Timo Aaltonen <email address hidden>
Now let's finish the Port-F support by adding the
proper port F detection, irq and power well support.
v2: Rebase
v3: Use BIT_ULL
v4: Cover missed case on ddi init.
v5: Update commit message.
v6: Rebase on top of display headers rework.
v7: Squash power-well handling related to DDI F to this
patch to avoid warns as pointed out by DK.
v8: Introduce DDI_F_LANES to PG2. (DK)
v9: Squash in the PORT_F case for enabling DP MST encoder. (DK)