Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers.
Interrupt moderation is currently not supported, so these accept and
display the default settings of 0 usec and 1 frame.
Toggle tx napi through setting tx-frames. So as to not interfere
with possible future interrupt moderation, value 1 means tx napi while
value 0 means not.
Only allow the switching when device is down for simplicity.
Link: https://patchwork.ozlabs.org/patch/948149/
Suggested-by: Jason Wang <email address hidden>
Signed-off-by: Willem de Bruijn <email address hidden>
Signed-off-by: Jason Wang <email address hidden>
Signed-off-by: David S. Miller <email address hidden>
(cherry picked from commit 0c465be183c7c57a26446df6ea96d8676b865f92)
Signed-off-by: Khalid Elmously <email address hidden>
Acked-by: Kleber Souza <email address hidden>
Acked-by: Sultan Alsawaf <email address hidden>
Signed-off-by: Khalid Elmously <email address hidden>
22e229f...
by
Willem de Bruijn <email address hidden>
NAPI tx mode improves TCP behavior by enabling TCP small queues (TSQ).
TSQ reduces queuing ("bufferbloat") and burstiness.
Previous measurements have shown significant improvement for
TCP_STREAM style workloads. Such as those in commit 86a5df1495cc
("Merge branch 'virtio-net-tx-napi'").
There has been uncertainty about smaller possible regressions in
latency due to increased reliance on tx interrupts.
The above results did not show that, nor did I observe this when
rerunning TCP_RR on Linux 5.1 this week on a pair of guests in the
same rack. This may be subject to other settings, notably interrupt
coalescing.
In the unlikely case of regression, we have landed a credible runtime
solution. Ethtool can configure it with -C tx-frames [0|1] as of
commit 0c465be183c7 ("virtio_net: ethtool tx napi configuration").
NAPI tx mode has been the default in Google Container-Optimized OS
(COS) for over half a year, as of release M70 in October 2018,
without any negative reports.
Link: https://marc.info/?l=linux-netdev&m=149305618416472
Link: https://lwn.net/Articles/507065/
Signed-off-by: Willem de Bruijn <email address hidden>
Acked-by: Michael S. Tsirkin <email address hidden>
Acked-by: Jason Wang <email address hidden>
Signed-off-by: David S. Miller <email address hidden>
(cherry picked from commit 31c03aef9bc22a64a8324d650ca4198819ef3a33 linux-next)
Signed-off-by: Marcelo Henrique Cerri <email address hidden>
Signed-off-by: Khalid Elmously <email address hidden>
Acked-by: Kleber Souza <email address hidden>
Acked-by: Sultan Alsawaf <email address hidden>
Signed-off-by: Khalid Elmously <email address hidden>
17ffa65...
by
Willem de Bruijn <email address hidden>