Merge ~canonical-kernel-team/+git/overlay-shiftfs-tests:systemd-tmpfiles-race into ~canonical-kernel-team/+git/overlay-shiftfs-tests:main

[Thadeu Lima de Souza Cascardo]

    ovl-mkdir-xattrs: avoid race with systemd-tmpfiles

    BugLink: https://bugs.launchpad.net/bugs/2034586

    systemd-tmpfiles-setup service might still run under a container just
    created, leading to a race where files under /tmp are removed during the
    test.

    Create the temporary directory under $HOME instead.

    Signed-off-by: Thadeu Lima de Souza Cascardo <email address hidden>

[Po-Hsu Lin (cypressyew)]

Thanks for fixing this.

review: Approve

diff --git a/tests/ovl-mkdir-xattrs.sh b/tests/ovl-mkdir-xattrs.sh
index 91bd996..8e4c1de 100755
--- a/tests/ovl-mkdir-xattrs.sh
+++ b/tests/ovl-mkdir-xattrs.sh
@@ -10,7 +10,7 @@ fi
 
 cat > test.sh <<'EOF'
 #!/bin/bash -xe
-dir=`mktemp -d`
+dir=`mktemp -p "${HOME}" -d`
 cleanup() {
  umount -l $dir/t
  rm -rf $dir