Merge ~canonical-kernel-team/+git/autotest-client-tests:phlin/kvm-x-fips into ~canonical-kernel-team/+git/autotest-client-tests:master

Proposed by Po-Hsu Lin
Status: Merged
Merge reported by: Po-Hsu Lin
Merged at revision: 4ca9713e1049dedc3addc76fa166e56c8d249f85
Proposed branch: ~canonical-kernel-team/+git/autotest-client-tests:phlin/kvm-x-fips
Merge into: ~canonical-kernel-team/+git/autotest-client-tests:master
Diff against target: 30 lines (+5/-0)
1 file modified
ubuntu_kvm_smoke_test/ubuntu_kvm_smoke_test.py (+5/-0)
Reviewer Review Type Date Requested Status
Magali Lemes do Sacramento Approve
Review via email: mp+464307@code.launchpad.net

Commit message

We will need to install the openssh-client-hmac for this test after
enabling the fipsdevppa support in our infrastructure code.

Otherwise it will fail with:
    fips: mandatory checksum data missing - aborting

It appears this package is only available in X and B.

To post a comment you must log in.
Revision history for this message
Magali Lemes do Sacramento (magalilemes) wrote :

LGTM!
(Assuming the successful build #4 for 4.4.0-1100.107 on the rizzo node for this test has this patch applied).
Thank youuuu!

review: Approve
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Yes that's correct, I forgot to mention this :D
Applied and pushed.
Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/ubuntu_kvm_smoke_test/ubuntu_kvm_smoke_test.py b/ubuntu_kvm_smoke_test/ubuntu_kvm_smoke_test.py
2index 0a89146..bbf3bbc 100644
3--- a/ubuntu_kvm_smoke_test/ubuntu_kvm_smoke_test.py
4+++ b/ubuntu_kvm_smoke_test/ubuntu_kvm_smoke_test.py
5@@ -2,6 +2,7 @@
6 #
7 import os
8 import platform
9+import re
10 from autotest.client import test, utils
11
12 class ubuntu_kvm_smoke_test(test.test):
13@@ -14,6 +15,7 @@ class ubuntu_kvm_smoke_test(test.test):
14 except AttributeError:
15 import distro
16 series = distro.codename()
17+ flavour = re.split('-\d*-', platform.uname()[2])[-1]
18 pkgs = [
19 'cpu-checker',
20 'uvtool',
21@@ -23,6 +25,9 @@ class ubuntu_kvm_smoke_test(test.test):
22 # available since Artful
23 if arch == 'aarch64' and series not in ['trusty', 'xenial']:
24 pkgs.append('qemu-efi-aarch64')
25+ if 'fips' in flavour and series in ['xenial', 'bionic']:
26+ # Ensure openssh-client-hmac is installed for fips kernel, this is available on X/B only LP: #2061365
27+ pkgs.append('openssh-client-hmac')
28
29 cmd = 'yes "" | DEBIAN_FRONTEND=noninteractive apt-get install --yes --force-yes ' + ' '.join(pkgs)
30 self.results = utils.system_output(cmd, retain_output=True)

Subscribers

People subscribed via source and target branches

to all changes: