Merge ~canonical-kernel-team/+git/autotest-client-tests:phlin/nbd-smk-setup into ~canonical-kernel-team/+git/autotest-client-tests:master

Proposed by Po-Hsu Lin
Status: Merged
Merge reported by: Po-Hsu Lin
Merged at revision: 4c1069f8beeb98b81ac2d3dcbc7f350bf8e3df66
Proposed branch: ~canonical-kernel-team/+git/autotest-client-tests:phlin/nbd-smk-setup
Merge into: ~canonical-kernel-team/+git/autotest-client-tests:master
Diff against target: 32 lines (+8/-3)
2 files modified
ubuntu_nbd_smoke_test/control (+5/-3)
ubuntu_nbd_smoke_test/ubuntu_nbd_smoke_test.py (+3/-0)
Reviewer Review Type Date Requested Status
Po-Hsu Lin Approve
Review via email: mp+463086@code.launchpad.net

Commit message

Create a pseudo setup test to split the package installation stage out.
It'll make it easier for us to know which part of the test is failing.

To post a comment you must log in.
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Self-approving.

review: Approve
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Applied and pushed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/ubuntu_nbd_smoke_test/control b/ubuntu_nbd_smoke_test/control
2index 1b5937a..b22997b 100644
3--- a/ubuntu_nbd_smoke_test/control
4+++ b/ubuntu_nbd_smoke_test/control
5@@ -10,8 +10,10 @@ TEST_CATEGORY = 'Functional'
6 TEST_TYPE = "client"
7 DOC = ""
8
9-name = 'ubuntu_nbd_smoke_test'
10-
11-results = job.run_test_detail('ubuntu_nbd_smoke_test', test_name='nbd-smoke-test', tag='nbd-smoke-test', timeout=900) # 15 min. timeout
12+result = job.run_test_detail(NAME, test_name='setup', tag='setup', timeout=60*30)
13+if result == 'GOOD':
14+ results = job.run_test_detail(NAME, test_name='nbd-smoke-test', tag='nbd-smoke-test', timeout=900) # 15 min. timeout
15+else:
16+ print("ERROR: test failed to build, skipping all the sub tests")
17
18 # vi:set ts=4 sw=4 expandtab syntax=python:
19diff --git a/ubuntu_nbd_smoke_test/ubuntu_nbd_smoke_test.py b/ubuntu_nbd_smoke_test/ubuntu_nbd_smoke_test.py
20index b3972dc..5718a3a 100644
21--- a/ubuntu_nbd_smoke_test/ubuntu_nbd_smoke_test.py
22+++ b/ubuntu_nbd_smoke_test/ubuntu_nbd_smoke_test.py
23@@ -52,6 +52,9 @@ class ubuntu_nbd_smoke_test(test.test):
24 #
25 # stress-ng "quick fire" short life tests
26 #
27+ if test_name == 'setup':
28+ return
29+
30 cmd = self.bindir + '/ubuntu_nbd_smoke_test.sh'
31 self.results = utils.system_output(cmd, retain_output=True)
32 #

Subscribers

People subscribed via source and target branches

to all changes: