Merge ~canonical-kernel-team/+git/autotest-client-tests:phlin/skip-netsniff-ng into ~canonical-kernel-team/+git/autotest-client-tests:master

Proposed by Po-Hsu Lin
Status: Merged
Merge reported by: Po-Hsu Lin
Merged at revision: b3a2712bda4ee3b3745c73b3a3126f3b88f15c8d
Proposed branch: ~canonical-kernel-team/+git/autotest-client-tests:phlin/skip-netsniff-ng
Merge into: ~canonical-kernel-team/+git/autotest-client-tests:master
Diff against target: 24 lines (+5/-1)
1 file modified
ubuntu_kselftests_net/ubuntu_kselftests_net.py (+5/-1)
Reviewer Review Type Date Requested Status
Magali Lemes do Sacramento Approve
Review via email: mp+462665@code.launchpad.net

Commit message

BugLink: https://bugs.launchpad.net/bugs/2054609

KERNTT-881
The netsniff-ng depends on the ntp package. But after we enabled the
fipsdevppa for installing FIPS compliant userspace tools, the ntp
installation will fail because it will try to run the MD5 sum which
is prohibited by FIPS.

Drop this package when testing FIPS kernels, the tradeoff is the
altnames.sh test will be skipped.

Description of the change

Patch tested on maas@obruchev and it's working as expected.

To post a comment you must log in.
Revision history for this message
Magali Lemes do Sacramento (magalilemes) wrote :

LGTM! Thanks

review: Approve
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Applied and pushed, thanks.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/ubuntu_kselftests_net/ubuntu_kselftests_net.py b/ubuntu_kselftests_net/ubuntu_kselftests_net.py
2index 9f1cd37..5267c10 100644
3--- a/ubuntu_kselftests_net/ubuntu_kselftests_net.py
4+++ b/ubuntu_kselftests_net/ubuntu_kselftests_net.py
5@@ -21,7 +21,6 @@ class ubuntu_kselftests_net(test.test):
6 'libfuse-dev', # For net:reuseport_bpf_numa
7 'libnuma-dev', # For net:reuseport_bpf_numa
8 'libssl-dev', # For net:tcp_mmap
9- 'netsniff-ng', # For net:altnames.sh
10 'net-tools', # For net:rtnetlink.sh
11 'pkg-config',
12 'tcpdump', # For net:cmsg_ipv6.sh
13@@ -30,6 +29,11 @@ class ubuntu_kselftests_net(test.test):
14 # For net:fib_tests.sh
15 if not self.series in ['trusty', 'xenial', 'bionic']:
16 pkgs.append('socat')
17+ # For net:altnames.sh
18+ if 'fips' not in self.flavour:
19+ # netsniff-ng depends on ntp, it will try to perorm a MD5 sum which is not allowed with FIPS kernels (LP: #2054609)
20+ pkgs.append('netsniff-ng')
21+
22 if not self.arch == 's390x':
23 if not self.series in ['trusty', 'xenial', 'bionic', 'focal', 'jammy']:
24 # With recent kernels BPF requires lld (LLVM-based linker) to

Subscribers

People subscribed via source and target branches

to all changes: