Merge ~canonical-kernel-team/+git/autotest-client-tests:phlin/ftrace-bump into ~canonical-kernel-team/+git/autotest-client-tests:master

Proposed by Po-Hsu Lin
Status: Merged
Merge reported by: Po-Hsu Lin
Merged at revision: 4790c714a0b39486d19a4683aff86a72c5fa32f4
Proposed branch: ~canonical-kernel-team/+git/autotest-client-tests:phlin/ftrace-bump
Merge into: ~canonical-kernel-team/+git/autotest-client-tests:master
Diff against target: 19 lines (+5/-3)
1 file modified
ubuntu_kselftests_ftrace/control (+5/-3)
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Review via email: mp+461479@code.launchpad.net

Commit message

BugLink: https://bugs.launchpad.net/bugs/2054789

ftrace:test.d--00basic--basic2.tc will take about 15 minutes to run on
a hardware with 288 CPU, and ftrace:test.d--direct--ftrace-direct.tc
will take about 120 minutes.

It's because it will spend about 6 seconds to offline a CPU during the
test. The more we have the longer it takes.

Bump the timeout threshold to 20 and 150 minutes respectively.

Also fix the arch check for amd64, platform.processor() is actually
returning 'x86_64' on AMD64 systems.

To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

+1

review: Approve
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Applied and pushed, uncommit changes removed.
Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/ubuntu_kselftests_ftrace/control b/ubuntu_kselftests_ftrace/control
2index 8dc0530..f460442 100644
3--- a/ubuntu_kselftests_ftrace/control
4+++ b/ubuntu_kselftests_ftrace/control
5@@ -52,9 +52,11 @@ if result == 'GOOD':
6 clean_name = ftrace_sub_test.split('/selftests/ftrace/')[1].replace('/', '--')
7 test = "{}:{}".format(category, clean_name)
8 timeout_threshold = default_timeout
9- if test == 'ftrace:test.d--direct--ftrace-direct.tc' and arch != 'riscv64':
10- timeout_threshold = 60 * 60 # LP: #2028839, it will take 46 mins to run on system with 224 CPUs
11- elif test == 'ftrace:test.d--event--subsystem-enable.tc' and arch == 'amd64':
12+ if test == 'ftrace:test.d--00basic--basic2.tc' and arch != 'riscv64':
13+ timeout_threshold = 60 * 20 # LP: #2054789, took 15 mins to run on system with 288 CPUs
14+ elif test == 'ftrace:test.d--direct--ftrace-direct.tc' and arch != 'riscv64':
15+ timeout_threshold = 60 * 150 # LP: #2028839, #2054789, took 120 mins to run on system with 288 CPUs
16+ elif test == 'ftrace:test.d--event--subsystem-enable.tc' and arch == 'x86_64':
17 timeout_threshold = 60 * 30 # LP: #2028839, it will take 18 mins to run on some amd64 systems
18 job.run_test_detail(NAME, test_name=test, tag=test, timeout=timeout_threshold)
19 else:

Subscribers

People subscribed via source and target branches

to all changes: