Merge ~canonical-kernel-team/+git/autotest-client-tests:phlin/fix-module-print into ~canonical-kernel-team/+git/autotest-client-tests:master

Proposed by Po-Hsu Lin
Status: Merged
Merge reported by: Po-Hsu Lin
Merged at revision: 6d8368b3fde3d00c2a93c1c2a4167d2b1b4a5bec
Proposed branch: ~canonical-kernel-team/+git/autotest-client-tests:phlin/fix-module-print
Merge into: ~canonical-kernel-team/+git/autotest-client-tests:master
Diff against target: 13 lines (+1/-1)
1 file modified
ubuntu_boot/kernel_taint_test.py (+1/-1)
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Review via email: mp+460764@code.launchpad.net

Commit message

The proprietary_modules returned from process_known_issues will be a
list, we should print out items iterated from the list like other
issues. Otherwise the output will be meaningless like:
* Modules with GPL Incompatible Licenses:
     n: v
     n: v
     n: v
     n: v
We got this issue because we used to print out the module name and its
license, but we stopped printing out the license since commit a339c326
"UBUNTU: SAUCE: ubuntu_boot: reconstruct kernel_tatinted check"

After this fix:
* Modules with GPL Incompatible Licenses:
     nvidia_uvm
     nvidia_drm
     nvidia_modeset
     nvidia

To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

+1

review: Approve
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Applied and pushed, thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/ubuntu_boot/kernel_taint_test.py b/ubuntu_boot/kernel_taint_test.py
2index baa6c72..8a350a8 100755
3--- a/ubuntu_boot/kernel_taint_test.py
4+++ b/ubuntu_boot/kernel_taint_test.py
5@@ -174,7 +174,7 @@ def main():
6 if proprietary_modules:
7 print("* Modules with GPL Incompatible Licenses:")
8 for mod in proprietary_modules:
9- print(" %s: %s" % (mod[0], mod[1]))
10+ print(" %s" % mod)
11 count += 1
12 else:
13 print("* Proprietary modules found, "

Subscribers

People subscribed via source and target branches

to all changes: