Merge ~canonical-kernel-team/+git/autotest-client-tests:phlin/performance-lowlatency-fix into ~canonical-kernel-team/+git/autotest-client-tests:master

Proposed by Po-Hsu Lin
Status: Merged
Merged at revision: 7e9a3d4219dd014e03f6de3777087a642867e1cc
Proposed branch: ~canonical-kernel-team/+git/autotest-client-tests:phlin/performance-lowlatency-fix
Merge into: ~canonical-kernel-team/+git/autotest-client-tests:master
Diff against target: 24 lines (+0/-2)
2 files modified
ubuntu_performance_pts/ubuntu_performance_pts.py (+0/-1)
ubuntu_performance_stream/ubuntu_performance_stream.py (+0/-1)
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Review via email: mp+456585@code.launchpad.net

Commit message

BugLink: https://bugs.launchpad.net/bugs/2045235

Installing linux-tools-generic and the linux-tools-VERSION-lowlatency
package altogether on a system running with lowlatency kernel will
cause dpkg error.

Remove the requirement for linux-tools-generic, as it's just a meta
package that pulls in linux-tools-VERSION-generic. Which will be done
with the following python code:
  'linux-tools-' + release

To post a comment you must log in.
Revision history for this message
Po-Hsu Lin (cypressyew) wrote (last edit ):

Patch running as uncommitted changes on maas@obruchev.

Tested with J-lowlatency and it's looking good.

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Also tested with J-generic, this patch did not cause regression.

Revision history for this message
Francis Ginther (fginther) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/ubuntu_performance_pts/ubuntu_performance_pts.py b/ubuntu_performance_pts/ubuntu_performance_pts.py
2index 5f23b5d..10ec868 100644
3--- a/ubuntu_performance_pts/ubuntu_performance_pts.py
4+++ b/ubuntu_performance_pts/ubuntu_performance_pts.py
5@@ -108,7 +108,6 @@ class ubuntu_performance_pts(test.test):
6 'libssl-dev',
7 'libpng-dev',
8 'autoconf',
9- 'linux-tools-generic',
10 'linux-tools-' + release,
11 'numactl'
12 ]
13diff --git a/ubuntu_performance_stream/ubuntu_performance_stream.py b/ubuntu_performance_stream/ubuntu_performance_stream.py
14index bbf805a..7f5c4a6 100644
15--- a/ubuntu_performance_stream/ubuntu_performance_stream.py
16+++ b/ubuntu_performance_stream/ubuntu_performance_stream.py
17@@ -107,7 +107,6 @@ class ubuntu_performance_stream(test.test):
18 pkgs = [
19 'gfortran',
20 'libgomp1',
21- 'linux-tools-generic',
22 'linux-tools-' + release
23
24 ]

Subscribers

People subscribed via source and target branches

to all changes: