Merge ~canonical-kernel-team/+git/autotest-client-tests:phlin/setup-rmaptest into ~canonical-kernel-team/+git/autotest-client-tests:master

Proposed by Po-Hsu Lin
Status: Merged
Merge reported by: Po-Hsu Lin
Merged at revision: 57b1fc9333c1abed95926b67fdf1f8fe60fef1f5
Proposed branch: ~canonical-kernel-team/+git/autotest-client-tests:phlin/setup-rmaptest
Merge into: ~canonical-kernel-team/+git/autotest-client-tests:master
Diff against target: 27 lines (+6/-2)
2 files modified
rmaptest/control (+3/-1)
rmaptest/rmaptest.py (+3/-1)
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Review via email: mp+454373@code.launchpad.net

Commit message

BugLink: https://bugs.launchpad.net/bugs/2040238

This test will take about 32.5 minutes to run on J-6.2 generic-64k ARM64
VM on openstack,

Separate the setup task so that we can know it's the test build or the
test itself is causing timeout, also bump to timeout to 40 minutes.

To post a comment you must log in.
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Note that we used to bump it once to 25 mins for older kernels in bug 2033498

Revision history for this message
Francis Ginther (fginther) wrote :

+1

review: Approve
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Applied with typo corrected (separate) in the title.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/rmaptest/control b/rmaptest/control
2index 1ce4a3f..7250fca 100644
3--- a/rmaptest/control
4+++ b/rmaptest/control
5@@ -12,4 +12,6 @@ DOC = """
6 Create lots of VMAs mapped by lots of tasks. To tickle objrmap and the
7 virtual scan.
8 """
9-job.run_test('rmaptest', timeout=60*25)
10+result = job.run_test_detail('rmaptest', test_name='setup', tag='setup', timeout=60*5)
11+if result == 'GOOD':
12+ job.run_test('rmaptest', test_name='rmaptest', tag='rmaptest', timeout=60*40)
13diff --git a/rmaptest/rmaptest.py b/rmaptest/rmaptest.py
14index 058dcac..d860dec 100644
15--- a/rmaptest/rmaptest.py
16+++ b/rmaptest/rmaptest.py
17@@ -40,7 +40,9 @@ class rmaptest(test.test):
18 os.chdir(self.srcdir)
19 utils.system(utils.get_cc() + ' -Wall -o rmaptest rmap-test.c')
20
21- def execute(self, args=''):
22+ def run_once(self, test_name, args=''):
23+ if test_name == 'setup':
24+ return
25 os.chdir(self.tmpdir)
26 for test in tests:
27 cmd = '%s/%s %s %s' % (self.srcdir, test[name], args, test[arglist])

Subscribers

People subscribed via source and target branches

to all changes: