Merge ~canonical-kernel-team/+git/autotest-client-tests:phlin/selftest-ftrace-cleanup into ~canonical-kernel-team/+git/autotest-client-tests:master

Proposed by Po-Hsu Lin
Status: Merged
Merge reported by: Po-Hsu Lin
Merged at revision: 0fe1ee36146ad894c891bd26be04c57243167350
Proposed branch: ~canonical-kernel-team/+git/autotest-client-tests:phlin/selftest-ftrace-cleanup
Merge into: ~canonical-kernel-team/+git/autotest-client-tests:master
Diff against target: 52 lines (+1/-29)
2 files modified
ubuntu_kernel_selftests/control (+1/-9)
ubuntu_kernel_selftests/ubuntu_kernel_selftests.py (+0/-20)
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Sean Feole Approve
Review via email: mp+451314@code.launchpad.net

Commit message

ftrace test has been moved into ubuntu_kselftests_ftrace, related code
can be removed now.

To post a comment you must log in.
Revision history for this message
Sean Feole (sfeole) wrote :

+1

review: Approve
Revision history for this message
Francis Ginther (fginther) wrote :

+1

review: Approve
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Patch applied, Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/ubuntu_kernel_selftests/control b/ubuntu_kernel_selftests/control
2index 396f870..33ec6af 100644
3--- a/ubuntu_kernel_selftests/control
4+++ b/ubuntu_kernel_selftests/control
5@@ -60,15 +60,7 @@ if result == 'GOOD':
6 tests = utils.system_output(cmd).split()
7 for item in tests:
8 timeout_threshold = arch_scale*60*45
9- if item == 'ftracetest':
10- if arch == 'riscv64':
11- # autotest timeout on riscv64 is incorrect (lp:1940080), disable it
12- # It takes about 22 mins on 5.15 and about 35 mins on 5.13
13- timeout_threshold = 0
14- else:
15- # ftracetest will take about ~60 minutes to run on some instances (lp:2008063)
16- timeout_threshold = 60 * 75
17- elif item == 'fcnal-test.sh':
18+ if item == 'fcnal-test.sh':
19 timeout_threshold = arch_scale*60*75 # lp:2006499, lp:2012016
20 test = "{}:{}".format(category, item)
21 job.run_test_detail(NAME, test_name=test, tag=test, timeout=timeout_threshold)
22diff --git a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
23index 496099b..cb6f8ef 100644
24--- a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
25+++ b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
26@@ -166,26 +166,6 @@ class ubuntu_kernel_selftests(test.test):
27 utils.system(cmd)
28
29 #
30- # Disable new ftrace tests that don't work reliably across
31- # architectures because of various symbols being checked
32- #
33- filenames = [
34- 'ftrace/func_stack_tracer.tc',
35- 'ftrace/func-filter-glob.tc',
36- 'trigger/inter-event/trigger-inter-event-combined-hist.tc',
37- 'trigger/inter-event/trigger-synthetic-event-createremove.tc',
38- 'trigger/trigger-hist.tc',
39- 'trigger/trigger-trace-marker-hist.tc',
40- 'kprobe/probepoint.tc',
41- 'kprobe/kprobe_module.tc',
42- ]
43-
44- for fn in filenames:
45- fn = 'linux/tools/testing/selftests/ftrace/test.d/' + fn
46- if os.path.exists(fn):
47- os.remove(fn)
48-
49- #
50 # ptrace/vmaccess was introduced in 5.7-rc1 and is broken ATM,
51 # see https://lkml.org/lkml/2020/4/9/648
52 #

Subscribers

People subscribed via source and target branches

to all changes: