Merge ~canonical-kernel-team/+git/autotest-client-tests:phlin/x-net-build into ~canonical-kernel-team/+git/autotest-client-tests:master

Proposed by Po-Hsu Lin
Status: Merged
Merge reported by: Po-Hsu Lin
Merged at revision: 51a7afc4c76033f0815f30b575fe06f64a28751c
Proposed branch: ~canonical-kernel-team/+git/autotest-client-tests:phlin/x-net-build
Merge into: ~canonical-kernel-team/+git/autotest-client-tests:master
Diff against target: 23 lines (+2/-3)
1 file modified
ubuntu_kernel_selftests/ubuntu_kernel_selftests.py (+2/-3)
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Sean Feole Approve
Review via email: mp+450759@code.launchpad.net

Commit message

BugLink: https://bugs.launchpad.net/bugs/2033520

The build for net tests on X-hwe-s390x will fail with:
  reuseport_bpf_numa.c:24:18: fatal error: numa.h: No such file or directory

Also reuseport_bpf_numa, reuseport_dualstack and reuseaddr_conflict tests
will fail to start because ther are not executable.

Add libnuma-dev and libfuse-dev directly to pkgs, we used to limit these
two for non T/X-s390x as they were not built for s390x back then.

These two packages are available for s390x now, and since we don't run
ubuntu_kernel_selftests on Trusty the if statement can be removed.

$ rmadison -a s390x libfuse-dev
 libfuse-dev | 2.9.4-1ubuntu3 | xenial | s390x
 libfuse-dev | 2.9.4-1ubuntu3.1 | xenial-updates | s390x
$ rmadison -a s390x libnuma-dev
 libnuma-dev | 2.0.11-1ubuntu1.1 | xenial-security | s390x
 libnuma-dev | 2.0.11-1ubuntu1.1 | xenial-updates | s390x

Description of the change

This has been tested with X-hwe-s390x as an uncommitted code on openstack@garlog.

To post a comment you must log in.
Revision history for this message
Sean Feole (sfeole) wrote :

+1

review: Approve
Revision history for this message
Francis Ginther (fginther) wrote :

+1

review: Approve
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Patch applied, thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
2index 496099b..d5cefac 100644
3--- a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
4+++ b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
5@@ -22,6 +22,8 @@ class ubuntu_kernel_selftests(test.test):
6 'iptables',
7 'jq',
8 'kernel-wedge',
9+ 'libfuse-dev'
10+ 'libnuma-dev',
11 'libssl-dev',
12 'netsniff-ng',
13 'net-tools',
14@@ -30,9 +32,6 @@ class ubuntu_kernel_selftests(test.test):
15 ]
16 if not self.series in ['trusty', 'xenial', 'bionic']:
17 pkgs.append('socat')
18- if not (self.arch == 's390x' and self.series in ['trusty', 'xenial']):
19- pkgs.append('libnuma-dev')
20- pkgs.append('libfuse-dev')
21 if not self.arch == 's390x':
22 if not self.series in ['trusty', 'xenial', 'bionic', 'focal', 'jammy']:
23 # With recent kernels BPF requires lld (LLVM-based linker) to

Subscribers

People subscribed via source and target branches

to all changes: