Merge ~canonical-kernel-team/+git/autotest-client-tests:phlin/ovl-smk-older-releases into ~canonical-kernel-team/+git/autotest-client-tests:master

Proposed by Po-Hsu Lin
Status: Merged
Merged at revision: 7d407fde363e3fe0656d198d61a55ae53892434b
Proposed branch: ~canonical-kernel-team/+git/autotest-client-tests:phlin/ovl-smk-older-releases
Merge into: ~canonical-kernel-team/+git/autotest-client-tests:master
Diff against target: 27 lines (+9/-0)
1 file modified
ubuntu_overlayfs_smoke_test/control (+9/-0)
Reviewer Review Type Date Requested Status
Sean Feole Approve
Francis Ginther Approve
Review via email: mp+449716@code.launchpad.net

Commit message

BugLink: https://bugs.launchpad.net/bugs/2032779

We have decided to run just the old ubuntu_overlayfs_smoke_test.sh test
on older release (< Focal). As the purpose of the new overlayfs/shift
tests is to have a better understanding of the custom features that we
bring as SAUCE patches and to make sure that newer kernels don't regress.

This would require changes in the overlay-shiftfs-tests repo as well.

To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

+1

review: Approve
Revision history for this message
Sean Feole (sfeole) wrote :

+1

review: Approve
Revision history for this message
Francis Ginther (fginther) wrote :

Appears to be applied, marked as merged.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/ubuntu_overlayfs_smoke_test/control b/ubuntu_overlayfs_smoke_test/control
2index baf2fbb..4471845 100644
3--- a/ubuntu_overlayfs_smoke_test/control
4+++ b/ubuntu_overlayfs_smoke_test/control
5@@ -12,6 +12,12 @@ DOC = "Test basic and sauce patch overlay/shiftfs functionality"
6
7 name = 'ubuntu_overlayfs_smoke_test'
8
9+try:
10+ series = platform.dist()[2]
11+except AttributeError:
12+ import distro
13+ series = distro.codename()
14+
15 # For skipping specific unit tests in incompatible environments
16 SKIP_LIST = [
17 ]
18@@ -26,6 +32,9 @@ if result == 'GOOD':
19 if 'shiftfs-hung.sh' in tests_list:
20 tests_list.remove('shiftfs-hung.sh')
21 tests_list.append('shiftfs-hung.sh')
22+ # Just run the old ubuntu_overlayfs_smoke_test.sh test on older releases LP: #2032779
23+ if 'ubuntu_overlayfs_smoke_test.sh' and series in ['trusty', 'xenial', 'bionic']:
24+ tests_list = ['ubuntu_overlayfs_smoke_test.sh']
25 for test in tests_list:
26 if test in SKIP_LIST:
27 print("SKIPPED: " + test)

Subscribers

People subscribed via source and target branches

to all changes: