Merge lp:~canonical-isd-hackers/drupal-openid/unittests into lp:drupal-openid/6.x

[Anthony Lenton]

[Anthony Lenton (elachuni)]

Added quite a few unittests, so tests are now split out in to multiple files in the tests/ folder.

No feature changes.

[lp:~canonical-isd-hackers/drupal-openid/unittests]

15. By Anthony Lenton on 2009-05-13

Code review fixes, plus updated the README.

[Łukasz Czyżykowski (lukasz-czyzykowski)]

review: Approve

=== removed file 'openid.test'
--- openid.test	2009-05-08 17:27:16 +0000
+++ openid.test	1970-01-01 00:00:00 +0000
@@ -1,50 +0,0 @@
-<?php
-
-class DrupalOpenIDHelpTestCase extends DrupalWebTestCase {
-  function getInfo() {
-    return array(
-      'name' => t('OpenID Help'),
-      'description' => t('Openid module Help unit tests'),
-      'group' => t('OpenID'),
-    );
-  }
-
-  function setUp() {
-    parent::setUp('openid');
-  }
-  /* Fetch all pages that show relevant OpenID help information */
-  function testDrupalOpenIDHelp() {
-      $user = $this->drupalCreateUser(array('access content', 'access administration pages'));
-      $this->drupalLogin($user);
-      $path = 'user/'. $user->uid.'/openid';
-      $this->drupalGet($path);
-      $this->assertText(t('This site supports OpenID'),
-                        t('Make sure the right help text appears on the user\'s OpenID page.'));
-      $this->drupalGet('admin/help/openid');
-      $this->assertText(t('OpenID is a secure method for logging into many websites'),
-                        t('Make sure the right help text appears on the admin help page.'));
-  }
-}
-
-class DrupalOpenIDBeginTestCase extends DrupalWebTestCase {
-  function getInfo() {
-    return array(
-      'name' => t('OpenID Begin'),
-      'description' => t('Openid begin unit tests'),
-      'group' => t('OpenID'),
-    );
-  }
-
-  function setUp() {
-    parent::setUp('openid');
-  }
-
-  /* Start an OpenID Authentication process */
-  function testOpenIDBegin() {
-      $edit = array('openid_identifier' => 'https://login.launchpad.net/');
-      $this->drupalPost('/user', $edit, 'Log in');
-      $this->assertFieldById('edit-openid-redirect-form', 'openid_redirect_form',
-                       t('Ensure clicking login produces a OpenID redirect form'));
-  }
-
-}

=== added directory 'tests'
=== added file 'tests/authentication.test'
--- tests/authentication.test	1970-01-01 00:00:00 +0000
+++ tests/authentication.test	2009-05-12 18:23:43 +0000
@@ -0,0 +1,56 @@
+<?php
+
+class DrupalOpenIDAuthenticationTestCase extends DrupalWebTestCase {
+  function getInfo() {
+    return array(
+      'name' => t('OpenID Authentication'),
+      'description' => t('openid_authentication unit tests'),
+      'group' => t('OpenID'),
+    );
+  }
+
+  function setUp() {
+    parent::setUp('openid', 'openid_test');
+  }
+
+  /* Fail to register a new account due to automatic user registration
+   *   being disabled */
+  function testOpenIDFailAuthentication() {
+      variable_set('user_register', FALSE);
+      $this->drupalGet('openid/test/login/doesntexist');
+      $this->assertText('Only site administrators can create new user accounts',
+                        'Ensure that a user account is *not* created');
+  }
+
+  /* Fail to register a new account due to not providing an email */
+  function testOpenIDNoEmailAuthentication() {
+      variable_set('user_register', TRUE);
+      variable_set('user_email_verification', FALSE);
+      $this->drupalGet('openid/test/loginnoemail/doesntexist');
+      $this->assertText('You must enter an e-mail address',
+                        'Ensure registration fails when an email is not provided');
+  }
+
+  function testOpenIDRegisterAuthentication() {
+      variable_set('user_register', TRUE);
+      $this->drupalGet('openid/test/login/doesntexist');
+      $this->assertText('My account',
+                        'Ensure an account was successfully created');
+  }
+
+  function testOpenIDVerifyEmailAuthentication() {
+      variable_set('user_register', TRUE);
+      variable_set('user_email_verification', TRUE);
+      $name = $this->randomName();
+      $mail = "$[e-mail]";
+      $this->drupalGet('openid/test/loginnoemail/' . $name);
+      $this->assertText('You must enter an e-mail address',
+                        'Ensure registration fails when an email is not provided');
+      $edit = array('name' => $name,
+              'mail' => $mail);
+      $this->drupalPost(NULL, $edit, 'Create new account');
+      $this->assertText('Once you have verified your email address, you may log in via OpenID',
+                        'Ensure an email notification warning is displayed');
+  }
+
+}

=== added file 'tests/begin.test'
--- tests/begin.test	1970-01-01 00:00:00 +0000
+++ tests/begin.test	2009-05-12 18:23:43 +0000
@@ -0,0 +1,32 @@
+<?php
+
+class DrupalOpenIDBeginTestCase extends DrupalWebTestCase {
+  function getInfo() {
+    return array(
+      'name' => t('OpenID Begin'),
+      'description' => t('openid_begin unit tests'),
+      'group' => t('OpenID'),
+    );
+  }
+
+  function setUp() {
+    parent::setUp('openid');
+  }
+
+  /* Start a good OpenID Authentication process */
+  function testOpenIDBegin() {
+      $edit = array('openid_identifier' => 'https://login.launchpad.net/');
+      $this->drupalPost('/user', $edit, 'Log in');
+      $this->assertFieldById('edit-openid-redirect-form', 'openid_redirect_form',
+                       t('Ensure clicking login produces a OpenID redirect form'));
+  }
+
+  /* Start an incorrect OpenID Authentication process */
+  function testOpenIDFailBegin() {
+      $edit = array('openid_identifier' => 'http://www.google.com/');
+      $this->drupalPost('/user', $edit, 'Log in');
+      $this->assertText('Sorry, that is not a valid OpenID.',
+                       'Ensure providing an invalid OpenID prints an error');
+  }
+
+}

=== added file 'tests/complete.test'
--- tests/complete.test	1970-01-01 00:00:00 +0000
+++ tests/complete.test	2009-05-12 18:23:43 +0000
@@ -0,0 +1,57 @@
+<?php
+
+class DrupalOpenIDCompleteTestCase extends DrupalWebTestCase {
+  function getInfo() {
+    return array(
+      'name' => t('OpenID Complete'),
+      'description' => t('openid_complete unit tests'),
+      'group' => t('OpenID'),
+    );
+  }
+
+  function setUp() {
+    parent::setUp('openid');
+  }
+
+  function testOpenIDCompleteEmpty() {
+      $response = array();
+      $result = openid_complete($response);
+      $this->assertEqual('failed', $result['status'],
+                         'Ensure that an empty request results in a "failed" status');
+  }
+
+  function testOpenIDCompleteCancelled() {
+      $response = array();
+      $response['openid.mode'] = 'cancel';
+      $_SESSION['openid']['service']['uri'] = 'http://provider.net';
+      $_SESSION['openid']['claimed_id'] = 'http://provider.net/myid';
+      
+      $result = openid_complete($response);
+      $this->assertEqual('cancel', $result['status'],
+                         'Ensure that a cancelled request results in a "cancel" status');
+  }
+
+  function testOpenIDCompleteSuccess() {
+      $response = array();
+      $response['openid.mode'] = 'success';
+      $response['openid.signed'] = 'afield,bfield';
+      $response['afield'] = 'aValue';
+      $response['bfield'] = 'bValue';
+      $_SESSION['openid']['service']['uri'] = 'http://provider.net';
+      $_SESSION['openid']['claimed_id'] = 'http://provider.net/myid';
+      $assoc = '{HMAC-SHA1}{01234567}{PHONEY==}';
+      $response['openid.assoc_handle'] = $assoc;
+      db_query("INSERT INTO {openid_association} (idp_endpoint_uri, session_type, assoc_handle, assoc_type, expires_in, mac_key, created) VALUES('%s', '%s', '%s', '%s', %d, '%s', %d)",
+               'http://provider.net/', 'DH-SHA1', $assoc, 'HMAC-SHA1', 1209600, 'tHisIsATotaLlyFakeMACKeyYay=', time());
+      module_load_include('inc', 'openid');
+      $association = db_fetch_object(db_query("SELECT * FROM {openid_association} WHERE assoc_handle = '%s'", $assoc));
+      $keys_to_sign = explode(',', $response['openid.signed']);
+      $self_sig = _openid_signature($association, $response, $keys_to_sign);
+      $response['openid.sig'] = $self_sig;
+
+      $result = openid_complete($response);
+      $this->assertEqual('success', $result['status'],
+                         'Ensure that a correct request results in a "success" status');
+  }
+}
+

=== added file 'tests/help.test'
--- tests/help.test	1970-01-01 00:00:00 +0000
+++ tests/help.test	2009-05-12 18:23:43 +0000
@@ -0,0 +1,28 @@
+<?php
+
+class DrupalOpenIDHelpTestCase extends DrupalWebTestCase {
+  function getInfo() {
+    return array(
+      'name' => t('OpenID Help'),
+      'description' => t('Openid module Help unit tests'),
+      'group' => t('OpenID'),
+    );
+  }
+
+  function setUp() {
+    parent::setUp('openid');
+  }
+  /* Fetch all pages that show relevant OpenID help information */
+  function testDrupalOpenIDHelp() {
+      $user = $this->drupalCreateUser(array('access content', 'access administration pages'));
+      $this->drupalLogin($user);
+      $path = 'user/'. $user->uid.'/openid';
+      $this->drupalGet($path);
+      $this->assertText(t('This site supports OpenID'),
+                        t('Make sure the right help text appears on the user\'s OpenID page.'));
+      $this->drupalGet('admin/help/openid');
+      $this->assertText(t('OpenID is a secure method for logging into many websites'),
+                        t('Make sure the right help text appears on the admin help page.'));
+  }
+}
+

=== added file 'tests/lowlevel.test'
--- tests/lowlevel.test	1970-01-01 00:00:00 +0000
+++ tests/lowlevel.test	2009-05-12 18:23:43 +0000
@@ -0,0 +1,94 @@
+<?php
+
+class DrupalOpenIDLowLevelTestCase extends DrupalWebTestCase {
+  function getInfo() {
+    return array(
+      'name' => t('OpenID Low Level'),
+      'description' => t('Exercises low-level OpenID functions'),
+      'group' => t('OpenID'),
+    );
+  }
+
+  function setUp() {
+    parent::setUp('openid');
+  }
+
+  function testOpenIDIsXRI() {
+    module_load_include('inc', 'openid');
+    $this->assertTrue(_openid_is_xri('@myid'), '@myid is a valid XRI');
+    $this->assertTrue(_openid_is_xri('=family'), '=family is a valid XRI');
+    $this->assertTrue(_openid_is_xri('xri://google'), 'xri://google is a valid XRI');
+    $this->assertFalse(_openid_is_xri('http://www.google.com'),
+                       'http://www.google.com is not a valid XRI');
+  }
+
+  function testOpenIDNormalizeXRI() {
+      module_load_include('inc', 'openid');
+      $this->assertEqual('@myid', _openid_normalize_xri('xri://@myid'),
+                         'xri://@myid is normalized to @myid');
+      $this->assertEqual('@myid', _openid_normalize_xri('@myid'),
+                         '@myid is normalized to @myid');
+  }
+
+  function testOpenIDNormalizeURL() {
+      module_load_include('inc', 'openid');
+      $this->assertEqual('http://lala/', _openid_normalize_url('lala'),
+                         'lala is normalized to http://lala/');
+      $this->assertEqual('http://lala/', _openid_normalize_url('http://lala'),
+                         'http://lala is normalized to http://lala/');
+      $this->assertEqual('http://lala/', _openid_normalize_url('http://lala/'),
+                         'http://lala/ is normalized to http://lala/');
+  }
+
+  function testOpenIDNormalize() {
+      module_load_include('inc', 'openid');
+      $this->assertEqual('@myid', _openid_normalize('xri://@myid'),
+                         'xri://@myid is normalized to @myid');
+      $this->assertEqual('http://lala/', _openid_normalize('lala'),
+                         'lala is normalized to http://lala/');
+  }
+
+  function testOpenIDCreateMessage() {
+      module_load_include('inc', 'openid');
+      $data = array("bad:data\n"=>"value\n");
+      $this->assertNull(_openid_create_message($data),
+                        'Bad data returns a NULL OpenID message');
+  }
+
+  function testOpenIDNonce() {
+      module_load_include('inc', 'openid');
+      $this->assertTrue(is_string(_openid_nonce()),
+                        'A nonce is generated');
+  }
+
+  function testOpenIDMetaLinkHref() {
+      module_load_include('inc', 'openid');
+      $html = '<link rel="stylesheet" href="style.css" />';
+      $rel = 'stylesheet';
+      $this->assertEqual('style.css', _openid_link_href($equiv, $html),
+                         'Ensure HRef is correctly extracted');
+      $this->assertFalse(_openid_link_href('openid.delegate', $html),
+                         'Ensure no HRef is extracted when not present');
+      
+  }
+
+  function testOpenIDMetaHTTPEquiv() {
+      module_load_include('inc', 'openid');
+      $html = '<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />';
+      $equiv = 'Content-Type';
+      $this->assertEqual('text/html; charset=utf-8',
+                         _openid_meta_httpequiv($equiv, $html),
+                         'Ensure HTTP-Equiv is correctly extracted');
+      $this->assertFalse(_openid_meta_httpequiv('X-XRDS-Location', $html),
+                         'No HTTP-Equiv is extracted when not present');
+      
+  }
+
+  function testOpenIDGetBytes() {
+      module_load_include('inc', 'openid');
+      $bytes = _openid_get_bytes(10);
+      $this->assertTrue(is_string($bytes) && strlen($bytes) == 10,
+                        '_openid_get_bytes returns the correct amount of random data');
+  }
+
+}

=== added file 'tests/openid_test.info'
--- tests/openid_test.info	1970-01-01 00:00:00 +0000
+++ tests/openid_test.info	2009-05-12 18:23:43 +0000
@@ -0,0 +1,8 @@
+; $Id$
+name = "OpenID Test"
+description = "Support module for OpenID tests"
+package = Testing
+version = VERSION
+core = 6.x
+files[] = openid_test.module
+hidden = TRUE

=== added file 'tests/openid_test.module'
--- tests/openid_test.module	1970-01-01 00:00:00 +0000
+++ tests/openid_test.module	2009-05-12 18:23:43 +0000
@@ -0,0 +1,58 @@
+<?php
+function openid_test_menu() {
+  return array(
+    'openid/test/login' => array(
+      'title' => 'Fake login',
+      'page callback' => 'fake_login_with_email',
+      'access arguments' => array('access content'),
+    ),
+    'openid/test/loginnoemail' => array(
+      'title' => 'Fake login w/o providing email',
+      'page callback' => 'fake_login_no_email',
+      'access arguments' => array('access content'),
+    ),
+  );
+}
+
+function fake_login_with_email($claimed_id) {
+    openid_test_fake_login($claimed_id, "{$claimed_id}@email.com");
+}
+
+function fake_login_no_email($claimed_id) {
+    openid_test_fake_login($claimed_id, '');
+}
+
+function openid_test_fake_login($claimed_id, $email) {
+    $_SESSION['openid']['service']['uri'] = $provider;
+    $_SESSION['openid']['claimed_id'] = $claimed_id;
+    $assoc = '{HMAC-SHA1}{01234567}{PHONEY==}';
+    $response['openid.assoc_handle'] = $assoc;
+    $provider = 'http://provider.net';
+    $response['openid.claimed_id'] = "{$provider}/{$claimed_id}";
+    $response['openid.identity'] = "{$provider}/{$claimed_id}";
+    $response['openid.mode'] = 'id_res';
+    //http%3A%2F%2Fspecs.openid.net%2Fauth%2F2.0
+    $response['openid.ns'] = 'http://specs.openid.net/auth/2.0';
+    //http%3A%2F%2Fopenid.net%2Fextensions%2Fsreg%2F1.1
+    $response['openid.ns.sreg'] = 'http://openid.net/extensions/sreg/1.1';
+    $response['openid.op_endpoint'] = "{$provider}/+openid";
+    $response['openid.response_nonce'] = 'noncense';
+    //http%3A%2F%2Flocalhost%2Fdrupal6%2Fopenid%2Fauthenticate%3Fdestination%3Dnode;
+    $response['openid.return_to'] = 'http://localhost/openid/authenticate/';
+    //assoc_handle%2Cclaimed_id%2Cidentity%2Cmode%2Cns%2Cns.sreg%2Cop_endpoint%2Cresponse_nonce%2Creturn_to%2Csigned%2Csreg.nickname
+    $response['openid.signed'] = 'assoc_handle,claimed_id,identity,mode,ns,ns.sreg,op_endpoint,response_nonce,return_to,signed,sreg.nickname,sreg.email';
+    $response['openid.sreg.nickname'] = $claimed_id;
+    $response['openid.sreg.email'] = $email;
+
+    db_query("DELETE FROM {openid_association} WHERE idp_endpoint_uri = '%s'", $provider);
+    db_query("INSERT INTO {openid_association} (idp_endpoint_uri, session_type, assoc_handle, assoc_type, expires_in, mac_key, created) VALUES('%s', '%s', '%s', '%s', %d, '%s', %d)",
+           $provider, 'DH-SHA1', $assoc, 'HMAC-SHA1', 1209600, 'tHisIsATotaLlyFakeMACKeyYay=', time());
+    module_load_include('inc', 'openid');
+    $association = db_fetch_object(db_query("SELECT * FROM {openid_association} WHERE assoc_handle = '%s'", $assoc));
+    $keys_to_sign = explode(',', $response['openid.signed']);
+    $self_sig = _openid_signature($association, $response, $keys_to_sign);
+    $keys_to_sign = explode(',', $response['openid.signed']);
+
+    openid_authentication($response);
+}
+

=== added file 'tests/pages.test'
--- tests/pages.test	1970-01-01 00:00:00 +0000
+++ tests/pages.test	2009-05-12 18:23:43 +0000
@@ -0,0 +1,77 @@
+<?php
+
+class DrupalOpenIDPagesTestCase extends DrupalWebTestCase {
+  function getInfo() {
+    return array(
+      'name' => t('OpenID Pages'),
+      'description' => t('OpenID Form generation unittests'),
+      'group' => t('OpenID'),
+    );
+  }
+
+  function setUp() {
+    parent::setUp('openid', 'openid_test');
+    $this->uid = 12345;
+    $this->aid = 432;
+    $this->authname = 'http://provider.net/myid';
+    $this->name = 'somebody';
+  }
+
+  function setUpAssociation() {
+    db_query("INSERT INTO {authmap} (uid, aid, authname, module) VALUES (%d, %d, '%s', '%s')",
+             $this->uid, $this->aid, $this->authname, 'openid');
+  }
+
+  function testOpenIDUserAdd() {
+    module_load_include('inc', 'openid', 'openid.pages');
+    variable_set('user_register', TRUE);
+    $this->drupalGet('openid/test/login/doesntexist');
+    $this->assertText('My account',
+                      'Ensure an account was successfully created');
+    $form = openid_user_add();
+    $this->assertTrue(is_array($form), 'Ensure a form was generated');
+  }
+
+  function testOpenIDUserDeleteForm() {
+      module_load_include('inc', 'openid', 'openid.pages.inc');
+      $form_state = array();
+      $account = (object)array('uid'=>$uid, 'name'=>$name);
+      $form = openid_user_delete_form($form_state, $account, $aid);
+      $this->assertEqual("Are you sure you want to delete the OpenID <em>{$authname}</em> for <em>{$name}</em>?",
+                         drupal_get_title(),
+                         'Ensure a confirmation screen is shown');
+      $form_state['values']['uid'] = $uid;
+      $form_state['values']['aid'] = $aid;
+      openid_user_delete_form_submit(array(), $form_state);
+      $this->assertEqual($form_state['redirect'], "user/{$uid}/openid",
+                         'Ensure we are redirected back to the OpenID management screen');
+  }
+
+  function testOpenIDUserIdentities() {
+      module_load_include('inc', 'openid', 'openid.pages.inc');
+      $account = (object)array('uid'=>$uid, 'name'=>$name);
+      $form = openid_user_identities($account);
+      $this->setUpAssociation();
+      $form = openid_user_identities($account);
+      
+  }
+
+  function testOpenIDUserAddSubmit() {
+      module_load_include('inc', 'openid', 'openid.pages.inc');
+      $form = array();
+      $form['openid_identifier']['#value'] = $this->authname;
+      $form_state = array();
+      openid_user_add_submit($form, $form_state);
+  }
+
+  function testOpenIDUserAddValidate() {
+      $form_state['values']['openid_identifier'] = $this->authname;
+      openid_user_add_validate(array(), $form_state);
+  }
+
+  function tearDown() {
+    db_query("DELETE FROM {authmap} WHERE uid=%d AND aid=%d AND authname='%s' AND module='%s'",
+             $this->uid, $this->aid, $this->authname, 'openid');
+    parent::tearDown();
+  }
+}

=== added file 'tests/verify_assertion.test'
--- tests/verify_assertion.test	1970-01-01 00:00:00 +0000
+++ tests/verify_assertion.test	2009-05-12 18:23:43 +0000
@@ -0,0 +1,53 @@
+<?php
+
+/**
+ * Verify openid_verify_assertion
+ */
+class DrupalOpenIDVerifyAssertionTestCase extends DrupalWebTestCase {
+  function getInfo() {
+    return array(
+      'name' => t('OpenID Verify Assertion'),
+      'description' => t('openid_verify_assertion unit tests'),
+      'group' => t('OpenID'),
+    );
+  }
+  function setUp() {
+    parent::setUp('openid');
+    $this->assoc = '{HMAC-SHA1}{01234567}{PHONEY==}';
+    $this->response = array('openid.assoc_handle' => $this->assoc,
+                      'openid.signed' => 'afield,bfield',
+                      'afield' => 'aValue',
+                      'bfield' => 'bValue');
+  }
+
+  function setUpAssociation() {
+    // Create an association
+    db_query("INSERT INTO {openid_association} (idp_endpoint_uri, session_type, assoc_handle, assoc_type, expires_in, mac_key, created) VALUES('%s', '%s', '%s', '%s', %d, '%s', %d)",
+             'http://provider.net/', 'DH-SHA1', $this->assoc, 'HMAC-SHA1', 1209600, 'tHisIsATotaLlyFakeMACKeyYay=', time());
+  }
+
+  function testOpenIDFailAssertion() {
+      $this->setUpAssociation();
+      $this->response['openid.sig'] = 'notAValidSignature';
+      $this->assertFalse(openid_verify_assertion('endpoint', $this->response),
+                         'Make sure openid_verify_assertion fails for an invalid signature');
+  }
+
+  function testOpenIDSucceedAssertion() {
+      $this->setUpAssociation();
+      module_load_include('inc', 'openid');
+      $association = db_fetch_object(db_query("SELECT * FROM {openid_association} WHERE assoc_handle = '%s'", $this->assoc));
+      $keys_to_sign = explode(',', $this->response['openid.signed']);
+      $self_sig = _openid_signature($association, $this->response, $keys_to_sign);
+      $this->response['openid.sig'] = $self_sig;
+      $this->assertTrue(openid_verify_assertion('endpoint', $this->response),
+                'Make sure openid_verify_assertion succeeds for a valid signature');
+  }
+
+  function testOpenIDCheckAssertion() {
+      $this->assertFalse(openid_verify_assertion('endpoint', $this->response),
+                'openid_verify_assertion fails when unable to check authentication');
+  }
+
+}
+