Merge lp:~canonical-isd-hackers/django-pgtools/fix-autocommit-errors into lp:django-pgtools

Proposed by Łukasz Czyżykowski
Status: Merged
Approved by: Michael Nelson
Approved revision: 7
Merged at revision: 4
Proposed branch: lp:~canonical-isd-hackers/django-pgtools/fix-autocommit-errors
Merge into: lp:django-pgtools
Diff against target: 102 lines (+13/-13)
2 files modified
debian/control (+1/-1)
tox.ini (+12/-12)
To merge this branch: bzr merge lp:~canonical-isd-hackers/django-pgtools/fix-autocommit-errors
Reviewer Review Type Date Requested Status
Michael Nelson (community) Approve
Review via email: mp+65327@code.launchpad.net

Commit message

Fix autocommit errors

Description of the change

Overview
========
This branch fixes failing jenkins errors by pinpointing psycopg2 version to the one which is known to work.

To post a comment you must log in.
Revision history for this message
Michael Nelson (michael.nelson) wrote :

{{{
13:25 < noodles> lukasz: that depends line doesn't make sense to me?
13:26 < lukasz> noodles, use version less than 2.4.2 or version greater than 2.4.2
13:26 < lukasz> which excluded 2.4.2
13:27 < noodles> 2.4.2~ubuntu1 or 2.4.2+ubuntu1?
13:27 < lukasz> noodles, nope, >> and << looks only on version part
13:27 < lukasz> without tags and ubuntu/debian versions
13:27 < noodles> Ah, great.
13:27 < lukasz> 2.4.1 and 2.4.3
13:30 < noodles> lukasz: one last question, why >> 2.4.2? Has the issue in 2.4.1 been fixed then?
13:31 < lukasz> noodles, that's being hopeful :)
13:31 < lukasz> and the issue is in 2.4.2
13:31 < lukasz> 2.4.1 is working
13:31 < noodles> In which case, why not just require 2.4.1 for the moment?
13:31 < lukasz> because lucid doesn't have 2.4.1
13:31 < lukasz> nor natty has
13:32 < noodles> Sorry, why not just require << 2.4.2 for the moment?
13:32 < lukasz> ok
13:33 < lukasz> noodles, pushed

}}}

review: Approve
Revision history for this message
ISD Branch Mangler (isd-branches-mangler) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2011-05-30 14:30:10 +0000
3+++ debian/control 2011-06-21 11:33:34 +0000
4@@ -14,7 +14,7 @@
5 XB-Python-Version: ${python:Versions}
6 Depends: ${misc:Depends}, ${python:Depends},
7 python-django (>= 1.0.2),
8- python-psycopg2
9+ python-psycopg2 (<< 2.4.2)
10 Description: Set of Django commands for managing PostgreSQL users.
11 Set of Django management commands for handling various aspects of managing
12 PostgreSQL database. Most important of which is ability to create database
13
14=== modified file 'tox.ini'
15--- tox.ini 2011-05-30 14:30:10 +0000
16+++ tox.ini 2011-06-21 11:33:34 +0000
17@@ -12,73 +12,73 @@
18 [testenv:py2.5-django1.2]
19 basepython = python2.5
20 deps = django >= 1.2, < 1.3
21- psycopg2
22+ psycopg2==2.4.1
23 mock
24
25 [testenv:py2.5-django1.1]
26 basepython = python2.5
27 deps = django >= 1.1, < 1.2
28- psycopg2
29+ psycopg2==2.4.1
30 mock
31
32 [testenv:py2.5-django1.0]
33 basetpython = python2.5
34 deps = django >= 1.0, < 1.1
35- psycopg2
36+ psycopg2==2.4.1
37 mock
38
39 [testenv:py2.5-django1.3]
40 basepython = python2.5
41 deps = django >= 1.3, < 1.4
42- psycopg2
43+ psycopg2==2.4.1
44 mock
45
46 # Python 2.6
47 [testenv:py2.6-django1.2]
48 basepython = python2.6
49 deps = django >= 1.2, < 1.3
50- psycopg2
51+ psycopg2==2.4.1
52 mock
53
54 [testenv:py2.6-django1.1]
55 basepython = python2.6
56 deps = django >= 1.1, < 1.2
57- psycopg2
58+ psycopg2==2.4.1
59 mock
60
61 [testenv:py2.6-django1.0]
62 basetpython = python2.6
63 deps = django >= 1.0, < 1.1
64- psycopg2
65+ psycopg2==2.4.1
66 mock
67
68 [testenv:py2.6-django1.3]
69 basepython = python2.6
70 deps = django >= 1.3, < 1.4
71- psycopg2
72+ psycopg2==2.4.1
73 mock
74
75 # Python 2.7
76 [testenv:py2.7-django1.2]
77 basepython = python2.7
78 deps = django >= 1.2, < 1.3
79- psycopg2
80+ psycopg2==2.4.1
81 mock
82
83 [testenv:py2.7-django1.1]
84 basepython = python2.7
85 deps = django >= 1.1, < 1.2
86- psycopg2
87+ psycopg2==2.4.1
88 mock
89
90 [testenv:py2.7-django1.0]
91 basetpython = python2.7
92 deps = django >= 1.0, < 1.1
93- psycopg2
94+ psycopg2==2.4.1
95 mock
96
97 [testenv:py2.7-django1.3]
98 basepython = python2.7
99 deps = django >= 1.3, < 1.4
100- psycopg2
101+ psycopg2==2.4.1
102 mock

Subscribers

People subscribed via source and target branches

to all changes: