Merge lp:~canonical-isd-hackers/canonical-identity-provider/sql-limit-for-openid-transactions into lp:canonical-identity-provider/release
Proposed by
Łukasz Czyżykowski
Status: | Merged |
---|---|
Approved by: | Ricardo Kirkner |
Approved revision: | no longer in the source branch. |
Merged at revision: | 225 |
Proposed branch: | lp:~canonical-isd-hackers/canonical-identity-provider/sql-limit-for-openid-transactions |
Merge into: | lp:canonical-identity-provider/release |
Diff against target: |
446 lines (+120/-71) 10 files modified
identityprovider/auth.py (+1/-1) identityprovider/forms.py (+8/-11) identityprovider/models/account.py (+21/-15) identityprovider/models/openidmodels.py (+33/-11) identityprovider/models/team.py (+15/-15) identityprovider/tests/test_models_openidmodels.py (+5/-9) identityprovider/tests/test_views_server.py (+16/-1) identityprovider/tests/test_views_ui.py (+4/-0) identityprovider/views/server.py (+1/-1) identityprovider/views/utils.py (+16/-7) |
To merge this branch: | bzr merge lp:~canonical-isd-hackers/canonical-identity-provider/sql-limit-for-openid-transactions |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Canonical ISD hackers | Pending | ||
Review via email:
|
Commit message
Database access improvements during OpenID transaction.
Description of the change
Overview
========
This branch limits number of SQL queries executed while processing OpenID transaction.
Improvement
===========
During an OpenID request, with all possible SReg fields and Teams extension, before this branch, there are 28 SQL queries executed. With this branch, that number is down to 12. The raw speed improvement is hard to quantify, as it requires database configured in very similar way as the production one.
To post a comment you must log in.