Merge lp:~canonical-isd-hackers/canonical-identity-provider/long-query into lp:canonical-identity-provider/release

[David Owen]

Index AuthToken's e-mail field, for quickly nullifying other tokens for a single address.

IMPORTANT NOTE: I based this revision off of the last revno in trunk that was from stable. This patch could be applied directly to stable, as we may want this change on production before deploying the newer features in trunk.

SSO has one query that takes up way more time than any other. This index enables that query to do a O(log N) index scan instead of an O(N) table scan, speeding it up by several orders of magnitude.

We don't currently have a way to manage migrations for SSO, so I added the effective changes (derived from Django's actual output) to SCHEMA_CHANGES.txt.

[Danny Tamez (zematynnad)]

Looks fine!

review: Approve

[David Owen (dsowen)]

@ricardo

IMO, unless we're ready to push the rest of trunk into the staging->production pipeline, then this patch should circumvent that so we can get its benefits more quickly.

Opinion?

=== added file 'SCHEMA_CHANGES.txt'
--- SCHEMA_CHANGES.txt	1970-01-01 00:00:00 +0000
+++ SCHEMA_CHANGES.txt	2011-11-14 22:31:24 +0000
@@ -0,0 +1,2 @@
+CREATE INDEX authtoken_email ON authtoken USING btree (email);
+CREATE INDEX authtoken_email_like ON authtoken USING btree (email text_pattern_ops);

=== modified file 'identityprovider/models/authtoken.py'
--- identityprovider/models/authtoken.py	2011-07-27 13:00:22 +0000
+++ identityprovider/models/authtoken.py	2011-11-14 22:31:24 +0000
@@ -48,7 +48,7 @@
     requester = models.ForeignKey(Account, db_column='requester',
         null=True, blank=True)
     requester_email = models.TextField(null=True, blank=True)
-    email = models.TextField()
+    email = models.TextField(db_index=True)
     redirection_url = models.TextField(null=True, blank=True)
 
     displayname = DisplaynameField(null=True)