Merge lp:~canonical-isd-hackers/canonical-identity-provider/flakes into lp:canonical-identity-provider/release

Proposed by David Owen
Status: Merged
Approved by: David Owen
Approved revision: no longer in the source branch.
Merged at revision: 253
Proposed branch: lp:~canonical-isd-hackers/canonical-identity-provider/flakes
Merge into: lp:canonical-identity-provider/release
Diff against target: 21 lines (+2/-2)
1 file modified
identityprovider/models/account.py (+2/-2)
To merge this branch: bzr merge lp:~canonical-isd-hackers/canonical-identity-provider/flakes
Reviewer Review Type Date Requested Status
Canonical ISD hackers Pending
Review via email: mp+86476@code.launchpad.net

Commit message

Reintroduced locally-scoped import to fix test

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'identityprovider/models/account.py'
2--- identityprovider/models/account.py 2011-12-20 21:33:34 +0000
3+++ identityprovider/models/account.py 2011-12-20 22:51:50 +0000
4@@ -12,8 +12,6 @@
5
6 from identityprovider.models.const import (AccountCreationRationale,
7 AccountStatus, EmailStatus)
8-
9-
10 from identityprovider.utils import (
11 encrypt_launchpad_password,
12 generate_openid_identifier,
13@@ -131,6 +129,8 @@
14 return sites.order_by('-date_last_used')
15
16 def _get_preferredemail(self):
17+ # import here to avoid circular dependancy issue
18+ from identityprovider.models.emailaddress import EmailAddress
19 if not hasattr(self, '_preferredemail'):
20 try:
21 email = None