Merge lp:~canonical-isd-hackers/canonical-identity-provider/fix-markup-showing-up into lp:canonical-identity-provider/release

Proposed by Łukasz Czyżykowski
Status: Merged
Merged at revision: 49
Proposed branch: lp:~canonical-isd-hackers/canonical-identity-provider/fix-markup-showing-up
Merge into: lp:canonical-identity-provider/release
Diff against target: 83 lines (+36/-1)
2 files modified
identityprovider/templates/widgets/unknown_rp.html (+1/-1)
identityprovider/tests/test_views_server.py (+35/-0)
To merge this branch: bzr merge lp:~canonical-isd-hackers/canonical-identity-provider/fix-markup-showing-up
Reviewer Review Type Date Requested Status
Szilveszter Farkas (community) Approve
Review via email: mp+26594@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Szilveszter Farkas (phanatic) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'identityprovider/templates/widgets/unknown_rp.html'
2--- identityprovider/templates/widgets/unknown_rp.html 2010-05-13 09:41:09 +0000
3+++ identityprovider/templates/widgets/unknown_rp.html 2010-06-04 14:45:33 +0000
4@@ -13,7 +13,7 @@
5 </p>
6 {% endif %}
7
8- <p class="grey">{{ brand.unknown_rp }}</p>
9+ <p class="grey">{{ brand.unknown_rp|safe }}</p>
10
11 <div>
12 <a href="{{ trust_root }}">{{ trust_root }}</a>
13
14=== modified file 'identityprovider/tests/test_views_server.py'
15--- identityprovider/tests/test_views_server.py 2010-05-27 15:38:35 +0000
16+++ identityprovider/tests/test_views_server.py 2010-06-04 14:45:33 +0000
17@@ -8,6 +8,7 @@
18 from django.contrib.auth.models import AnonymousUser
19 from openid.extensions import pape
20 from openid.extensions.sreg import SRegRequest
21+
22 from openid.message import Message, OPENID2_NS, IDENTIFIER_SELECT
23 from openid.server.server import Server, ProtocolError
24 from openid.yadis.constants import YADIS_HEADER_NAME
25@@ -20,6 +21,7 @@
26 AccountCreationRationale)
27 from identityprovider.models.person import PersonLocation
28 from identityprovider.models.authtoken import create_token
29+
30 from identityprovider.views import server
31 from identityprovider.tests.utils import (SQLCachedTestCase,
32 BasicAccountTestCase, AuthenticatedTestCase, OpenIDProviderTestCase)
33@@ -31,13 +33,29 @@
34 class DummyORequest(object):
35 mode = 'checkid_setup'
36 trust_root = 'http://localhost/'
37+ message = Message()
38 identity = 'http://localhost/+id/mark_oid'
39
40 def idSelect(self):
41 return False
42
43+class DummySession(dict):
44+
45+ @property
46+ def session_key(self):
47+ return 'abc'
48+
49+ def flush(self): pass
50+
51
52 class DummyRequest(object):
53+
54+ def __init__(self):
55+ self.session = DummySession()
56+
57+
58+class UntrustedRPTest(SQLCachedTestCase):
59+
60 def __init__(self, META=None, REQUEST=None):
61 class MockSession(dict):
62 def __init__(self):
63@@ -782,3 +800,20 @@
64 team = Person.objects.get(name=team_name)
65 team.visibility = PERSON_VISIBILITY_PRIVATE_MEMBERSHIP
66 team.save()
67+
68+
69+class DecideTestCase(BasicAccountTestCase):
70+
71+ fixtures = ["test"]
72+ pgsql_functions = ["generate_openid_identifier"]
73+
74+ def test_unknown_rp(self):
75+ self.client.login(username='mark@example.com', password='test')
76+
77+ session = self.client.session
78+ token = 'a' * 16
79+ session[token] = signed.dumps(DummyORequest())
80+ session.save()
81+
82+ r = self.client.get('/%s/+decide' % token)
83+ self.assertContains(r, '<em>not</em>')