Merge lp:~canonical-isd-hackers/canonical-identity-provider/email_screen into lp:~canonical-isd-hackers/canonical-identity-provider/stable

Proposed by David Owen
Status: Merged
Merged at revision: 41
Proposed branch: lp:~canonical-isd-hackers/canonical-identity-provider/email_screen
Merge into: lp:~canonical-isd-hackers/canonical-identity-provider/stable
Diff against target: 51 lines (+7/-5)
3 files modified
doctests/stories/sso-server/standalone-login.txt (+1/-1)
identityprovider/templates/account/emails.html (+6/-3)
identityprovider/templates/widgets/ubuntu/logout-button.html (+0/-1)
To merge this branch: bzr merge lp:~canonical-isd-hackers/canonical-identity-provider/email_screen
Reviewer Review Type Date Requested Status
Ricardo Kirkner (community) Approve
Review via email: mp+30138@code.launchpad.net

Description of the change

Changes navigation to and from the email addresses screen, according to Stuart's suggestion in the bug report.

To post a comment you must log in.
Revision history for this message
Ricardo Kirkner (ricardokirkner) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'doctests/stories/sso-server/standalone-login.txt'
2--- doctests/stories/sso-server/standalone-login.txt 2010-07-12 22:49:50 +0000
3+++ doctests/stories/sso-server/standalone-login.txt 2010-07-16 18:57:40 +0000
4@@ -212,7 +212,7 @@
5
6 >>> def add_email(browser, email):
7 ... browser.open('http://openid.launchpad.dev/+edit')
8- ... browser.getLink('Email addresses').click()
9+ ... browser.getLink('Manage email addresses').click()
10 ... browser.getControl(name='newemail').value = email
11 ... browser.getControl(name='continue').click()
12
13
14=== modified file 'identityprovider/templates/account/emails.html'
15--- identityprovider/templates/account/emails.html 2010-07-13 15:48:43 +0000
16+++ identityprovider/templates/account/emails.html 2010-07-16 18:57:40 +0000
17@@ -1,9 +1,11 @@
18-<!-- Copyright 2010 Canonical Ltd. This software is licensed under the
19-GNU Affero General Public License version 3 (see the file LICENSE). -->
20-
21 {% extends "base.html" %}
22 {% load i18n %}
23
24+{% comment %}
25+Copyright 2010 Canonical Ltd. This software is licensed under the
26+GNU Affero General Public License version 3 (see the file LICENSE).
27+{% endcomment %}
28+
29 {% block title %}
30 {% blocktrans %}{{ account_displayname }}'s email addresses{% endblocktrans %}
31 {% endblock %}
32@@ -95,6 +97,7 @@
33 <button type="submit" class="btn" name="continue">
34 <span><span>{% trans "Add address" %}</span></span>
35 </button>
36+ {% blocktrans %}or <a href="/">cancel</a>{% endblocktrans %}
37 </p>
38 </form>
39
40
41=== modified file 'identityprovider/templates/widgets/ubuntu/logout-button.html'
42--- identityprovider/templates/widgets/ubuntu/logout-button.html 2010-07-13 16:15:10 +0000
43+++ identityprovider/templates/widgets/ubuntu/logout-button.html 2010-07-16 18:57:40 +0000
44@@ -9,7 +9,6 @@
45 <ul>
46
47 {% menu_item "account" user.displayname "/" %}
48-{% menu_item "emails" _("Email addresses") "/+emails" %}
49
50 {% if token and not readonly %}
51 {% menu_item "edit" _("Edit") "./+edit" %}

Subscribers

People subscribed via source and target branches

to all changes: