Merge juju-bmc:update-snapcraft-plugs-naming into juju-bmc:master

Proposed by Jose Guedez
Status: Merged
Approved by: Jose Guedez
Approved revision: 88bdfdae0c2cebf101c510322c023691b24c4e06
Merged at revision: 51f726be644756cde50c5b1917dde6a5178cfaca
Proposed branch: juju-bmc:update-snapcraft-plugs-naming
Merge into: juju-bmc:master
Diff against target: 32 lines (+7/-5)
1 file modified
snap/snapcraft.yaml (+7/-5)
Reviewer Review Type Date Requested Status
Joe Guo (community) Approve
Review via email: mp+385444@code.launchpad.net

Commit message

update snapcraft.yaml plugs per suggestions from snap review

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Jose Guedez (jfguedez) wrote :

Changes to address comments during snap review - https://forum.snapcraft.io/t/juju-bmc-request-to-use-personal-files/18065

Already tested in a couple clouds.

Revision history for this message
Joe Guo (guoqiao) wrote :

LGTM, +1.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 51f726be644756cde50c5b1917dde6a5178cfaca

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index 0522094..e58e4d0 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -11,20 +11,22 @@ grade: devel # must be 'stable' to release into candidate/stable channels
6 confinement: strict
7
8 plugs:
9- config-files:
10+ dot-maascli-db:
11 interface: personal-files
12- read:
13- - $HOME/.maascli.db
14- - $HOME/.local/share/juju
15 write:
16 - $HOME/.maascli.db
17+ dot-local-share-juju:
18+ interface: personal-files
19+ read:
20+ - $HOME/.local/share/juju
21
22 apps:
23 juju-bmc:
24 command: bin/juju-bmc
25 plugs:
26 - network
27- - config-files
28+ - dot-maascli-db
29+ - dot-local-share-juju
30 - ssh-keys
31
32 parts:

Subscribers

People subscribed via source and target branches

to all changes: