Merge ~canonical-is-bootstack/charm-memcached:fix/functests into charm-memcached:master

Proposed by Alvaro Uria
Status: Merged
Approved by: Alvaro Uria
Approved revision: 6ecb455b0b1cac05b24bf6a2129e27858b05c0a3
Merged at revision: 892cb7a55ac5a5aa19e92b0aa10ebb8e5317960a
Proposed branch: ~canonical-is-bootstack/charm-memcached:fix/functests
Merge into: charm-memcached:master
Diff against target: 13 lines (+3/-0)
1 file modified
tests/functional/tests/tests.yaml (+3/-0)
Reviewer Review Type Date Requested Status
Alvaro Uria (community) Approve
Drew Freiberger (community) Approve
Review via email: mp+392365@code.launchpad.net

Commit message

Func tests: add nrpe expected workload status

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Alvaro Uria (aluria) wrote :

This change has been tested and makes func tests pass. If the nrpe workload messages are not included, func tests will hang until timeout because the nrpe application does not match the expected status (blocked because it is not related to a nagios application).

Revision history for this message
Drew Freiberger (afreiberger) wrote :

+1 lgtm. This has been our standard fix this cycle due to 20.08 nrpe status change.

review: Approve
Revision history for this message
Alvaro Uria (aluria) wrote :

Trivial fix, so also approving it myself.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 892cb7a55ac5a5aa19e92b0aa10ebb8e5317960a

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tests/functional/tests/tests.yaml b/tests/functional/tests/tests.yaml
2index d48a5cb..aeb9336 100644
3--- a/tests/functional/tests/tests.yaml
4+++ b/tests/functional/tests/tests.yaml
5@@ -13,5 +13,8 @@ target_deploy_status:
6 mediawiki:
7 workload-status: blocked
8 workload-status-message: Database required
9+ nrpe:
10+ workload-status: blocked
11+ workload-status-message: Nagios server not configured or related
12 tests:
13 - tests.test_memcached.CharmOperationTest

Subscribers

People subscribed via source and target branches

to all changes: