Merge ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:for-hwe/lp-1828147 into ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:ubuntu/master

Proposed by You-Sheng Yang
Status: Merged
Approved by: You-Sheng Yang
Approved revision: 31e7b124a2ce586dbffcba9140e9c4947830d259
Merged at revision: 84d94a618bea8026e993f9ba078bf3db0a05d8a1
Proposed branch: ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:for-hwe/lp-1828147
Merge into: ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:ubuntu/master
Diff against target: 55 lines (+36/-0)
3 files modified
debian/changelog (+6/-0)
debian/patches/0001-UBUNTU-SAUCE-iwlwifi-trans-fix-killer-series-loadded-incor.patch (+29/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
AceLan Kao Approve
You-Sheng Yang Approve
Review via email: mp+367972@code.launchpad.net

Commit message

UBUNTU: SAUCE: iwlwifi: trans: fix killer series loadded incorrect firmware

BugLink: https://bugs.launchpad.net/bugs/1830822

Description of the change

Killer series loadded IWL_22000_HR_B_FW_PRE prefixed firmware instead IWL_CC_A_FW_PRE prefixed firmware. This patch adds killer series to the check logic as iwl_ax200_cfg_cc.

Since upstream has already a similar patch in stage but yet ready to publish all out, this is added to patch queue for now and will be removed when the corresponding upstream fix is rolled out.

To post a comment you must log in.
Revision history for this message
You-Sheng Yang (vicamo) wrote :

Need public bug.

review: Needs Fixing
Revision history for this message
You-Sheng Yang (vicamo) wrote :
Revision history for this message
You-Sheng Yang (vicamo) wrote :

* Updated public bug url
* Updated title to include "SAUCE: "

Revision history for this message
You-Sheng Yang (vicamo) wrote :

verified

review: Approve
Revision history for this message
AceLan Kao (acelankao) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index c60d4d6..f38a53b 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+iwlwifi-dkms (7744-ubuntu1) UNRELEASED; urgency=low
7+
8+ * Close lp:1830822.
9+
10+ -- You-Sheng Yang <vicamo@gmail.com> Tue, 28 May 2019 15:53:12 +0800
11+
12 iwlwifi-dkms (7744) UNRELEASED; urgency=low
13
14 * Initial release
15diff --git a/debian/patches/0001-UBUNTU-SAUCE-iwlwifi-trans-fix-killer-series-loadded-incor.patch b/debian/patches/0001-UBUNTU-SAUCE-iwlwifi-trans-fix-killer-series-loadded-incor.patch
16new file mode 100644
17index 0000000..af8b238
18--- /dev/null
19+++ b/debian/patches/0001-UBUNTU-SAUCE-iwlwifi-trans-fix-killer-series-loadded-incor.patch
20@@ -0,0 +1,29 @@
21+From: Cyrus Lien <cyruslien@gmail.com>
22+Date: Mon, 13 May 2019 13:33:35 +0000
23+Subject: UBUNTU: SAUCE: iwlwifi: trans: fix killer series loadded incorrect firmware
24+
25+Killer series loadded IWL_22000_HR_B_FW_PRE prefixed firmware instead
26+IWL_CC_A_FW_PRE prefixed firmware.
27+
28+Add killer series to the check logic as iwl_ax200_cfg_cc.
29+
30+Signed-off-by: Cyrus Lien <cyrus.lien@canonical.com>
31+---
32+ drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 4 +++-
33+ 1 file changed, 3 insertions(+), 1 deletion(-)
34+
35+diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
36+index b2e4c73..82a7384 100644
37+--- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
38++++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
39+@@ -3640,7 +3640,9 @@ struct iwl_trans *iwl_trans_pcie_alloc(struct pci_dev *pdev,
40+ }
41+ } else if (CSR_HW_RF_ID_TYPE_CHIP_ID(trans->hw_rf_id) ==
42+ CSR_HW_RF_ID_TYPE_CHIP_ID(CSR_HW_RF_ID_TYPE_HR) &&
43+- (trans->cfg != &iwl_ax200_cfg_cc ||
44++ ((trans->cfg != &iwl_ax200_cfg_cc &&
45++ trans->cfg != &killer1650x_2ax_cfg &&
46++ trans->cfg != &killer1650w_2ax_cfg) ||
47+ trans->hw_rev == CSR_HW_REV_TYPE_QNJ_B0)) {
48+ u32 hw_status;
49+
50diff --git a/debian/patches/series b/debian/patches/series
51index e69de29..402fa27 100644
52--- a/debian/patches/series
53+++ b/debian/patches/series
54@@ -0,0 +1 @@
55+0001-UBUNTU-SAUCE-iwlwifi-trans-fix-killer-series-loadded-incor.patch

Subscribers

People subscribed via source and target branches