topology: sof-hda-generic-kwd: switch to use vol-kfbm mode
We need PGA to tune the volume for the KWD pipeline, switch to use
vol-kfbm mode to get it done.
Signed-off-by: Keyon Jie <email address hidden>
b4e7150...
by
Bartosz Kokoszko <email address hidden>
mn: clear mclk and bclk source clks in MDIVCTRL
We should clear MNDSS and MCDSS bits before setting
new mclk and bclks source clocks. This commit is
going to fix case when driver want to reconfigure
the same SSP (e.g. index = 0).
1. Driver sends ssp_config() and FW configures ssp
(index = 0) with MCDSS bits set to e.g. 1.
2. Driver wants to reconfigure the same ssp (index = 0)
by sending new ssp_config() and FW tries to configure
ssp 0 once again, but firstly it reads MDIVCTRL
register:
mdivc = mn_reg_read(MN_MDIVCTRL, mclk_id)
and then tries to set MCDSS(0):
mdivc |= MCDSS(0);
, but there is "or" function here - after it MCDSS bits
still will be set to 1. That's why we should clear this
bits earlier.
Parameter validation should give detailed information about wrong
settings to speed up the troubleshooting.
Signed-off-by: Marcin Maka <email address hidden>
6bae156...
by
Seppo Ingalsuo <email address hidden>
Audio: Make volume gain ramp update rate variable
This patch adds to volume component capability to use one of
four ramp update rate presets 125 to 1000 us depending on topology
defined ramp length that is typically between 20 to 250 ms. The
rate needs to be higher for faster ramps to avoid zipper noise.
Signed-off-by: Seppo Ingalsuo <email address hidden>
3dc0ae9...
by
Seppo Ingalsuo <email address hidden>
Audio: Improve volume ramp time calculation precision
This patch changes the ramp time (from ramp start) calculation
unit from millisecond to Q29.3 milliseconds. It changes the smallest
time difference and therefore ramp slop point value down to 125 us
so finer than 1000 us volume update rate can be used. E.g. update
rates 125/250/500 us are good choices for high update rate.
The higher ramp update rates can be defined in volume.h if the volume
ramp need to be much shorter than currently while avoiding
audible zipper noise.
Signed-off-by: Seppo Ingalsuo <email address hidden>