subiquity:noble-late-commands

Last commit made on 2024-06-25
Get this branch:
git clone -b noble-late-commands https://git.launchpad.net/subiquity

Branch merges

Branch information

Name:
noble-late-commands
Repository:
lp:subiquity

Recent commits

9da3bca... by Olivier Gayot

unattended-upgrades: Use run_curtin_command instead of start_curtin_command

Since we removed the ability to interrupt the unattended-upgrades
process, we can use run_curtin_command instead of start_curtin_command.

Signed-off-by: Olivier Gayot <email address hidden>
(cherry picked from commit ae581d90adb6f3c1f6a065a17208d079556f6e02)

1c46cb0... by Dan Bungert

state: remove UU_CANCELLING state which is broken and misleading

Last cycle, to make the installation faster, we decided to disable the
unattended-upgrades minimal steps. This prevents proper handling of
unattended-upgrades cancellation so we now drop the feature completely.

Furthermore, the status reported on the text installer UI is misleading
when unattended-upgrades is running.

(cherry picked from commit a39fb0391c49337de7c4dcfc612f95ee7af07cbb)

2848765... by Dan Bungert

state: add LATE_COMMANDS as an explicit state

Today, late-commands can in some cases not actually run, if the
application reports a DONE state and a reboot is permitted.

We now add LATE_COMMANDS to track this explicit state - we no longer
transition to a DONE state while these commands are running.

(cherry picked from commit dd006d071c800eb39a578dd1eb20469754ef2802)

d52404d... by Olivier Gayot

Merge pull request #2007 from ogayot/noble-nvme-restricted-probe

Noble merge - Probe NVMe controllers when running the restricted probe

d224f1e... by Chris Peterson

Merge pull request #2006 from Chris-Peterson444/netboot-cherry-pick

Cherry-pick fix for Netboot bug LP: #2062988 to ubuntu/noble

fd1a272... by Olivier Gayot

filesystem: probe NVMe controllers when running the restricted probe

If block probing times out, we rerun it with the restricted set of
probes. Sadly, the restricted set does not include "nvme" so we do not
enumerate NVMe controllers. This leads to the following error if NVMe
storage devices are present:

  File "subiquity/models/filesystem.py", line 1492, in reset
    self.process_probe_data()
  File "subiquity/models/filesystem.py", line 1512, in process_probe_data
    self._orig_config = storage_config.extract_storage_config(self._probe_data)[
  File "/site-packages/curtin/storage_config.py", line 1420, in extract_storage_config
    tree = get_config_tree(cfg.get('id'), final_config)
  File "/site-packages/curtin/storage_config.py", line 313, in get_config_tree
    for dep in find_item_dependencies(item, sconfig):
  File "/site-packages/curtin/storage_config.py", line 283, in find_item_dependencies
    _validate_dep_type(item_id, dep_key, dep, config)
  File "/site-packages/curtin/storage_config.py", line 230, in _validate_dep_type
    raise ValueError(
ValueError: Invalid dep_id (nvme-controller-nvme0) not in storage config

Fixed by also enumerating NVMe controllers as part of the restricted
probe operation.

Signed-off-by: Olivier Gayot <email address hidden>
(cherry picked from commit 92a47635d8a988b4cc40a9a9d23d396c8c2a51c0)

9d0dcdd... by Chris Peterson

cc-extract: don't unnecessarily access data

We currently don't have plans to do anything with the _data_ of the
keys that fail to validate by cloud-init; and trying to access this
data has the potential to crash the installer if it doesn't exist,
at least at the top level (LP: #2062988).

(cherry picked from commit 1ef2b0741ac91110a1bdff8ed948c6d6f286d6ce)

74c37fe... by Dan Bungert

Merge pull request #1976 from ogayot/curtin-string-interpolation

snapcraft: bump curtin rev for ZFS string interpolation fix

4bbab28... by Olivier Gayot

snapcraft: bump curtin rev for ZFS string interpolation fix

Signed-off-by: Olivier Gayot <email address hidden>

aaf0d56... by Olivier Gayot

Merge pull request #1968 from ogayot/server-ignore-mirror-test-offline

mirror: if the mirror test fails, suggest an offline install