Merge lp:~canonical-dx-team/unity/unity.fix-697791 into lp:unity

Proposed by Mirco Müller
Status: Merged
Approved by: Gord Allott
Approved revision: no longer in the source branch.
Merged at revision: 738
Proposed branch: lp:~canonical-dx-team/unity/unity.fix-697791
Merge into: lp:unity
Diff against target: 119 lines (+2/-68)
2 files modified
src/StaticCairoText.cpp (+1/-1)
src/Tooltip.cpp (+1/-67)
To merge this branch: bzr merge lp:~canonical-dx-team/unity/unity.fix-697791
Reviewer Review Type Date Requested Status
Unity Team Pending
Review via email: mp+45372@code.launchpad.net

Description of the change

Corrected slight alignment-issue of text position. Fixes LP: #697791

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/StaticCairoText.cpp'
2--- src/StaticCairoText.cpp 2011-01-04 04:28:22 +0000
3+++ src/StaticCairoText.cpp 2011-01-06 13:59:08 +0000
4@@ -283,7 +283,7 @@
5
6 pango_layout_context_changed (layout);
7
8- cairo_move_to (cr, 0.0f, 0.0f);
9+ cairo_move_to (cr, -1.0f, 1.0f);
10 pango_cairo_show_layout (cr, layout);
11
12 // clean up
13
14=== modified file 'src/Tooltip.cpp'
15--- src/Tooltip.cpp 2011-01-04 04:28:22 +0000
16+++ src/Tooltip.cpp 2011-01-06 13:59:08 +0000
17@@ -423,15 +423,6 @@
18 gfloat* rgba_hl,
19 gfloat* rgba_dot)
20 {
21- /*cairo_surface_t* dots_surf = NULL;
22- cairo_t* dots_cr = NULL;
23- cairo_pattern_t* dots_pattern = NULL;
24- cairo_pattern_t* hl_pattern = NULL;*/
25-
26- // create context for dot-pattern
27- /*dots_surf = cairo_image_surface_create (CAIRO_FORMAT_ARGB32, 4, 4);
28- dots_cr = cairo_create (dots_surf);*/
29-
30 // clear normal context
31 cairo_scale (cr, 1.0f, 1.0f);
32 cairo_set_source_rgba (cr, 0.0f, 0.0f, 0.0f, 0.0f);
33@@ -450,52 +441,7 @@
34 rgba_tint[1],
35 rgba_tint[2],
36 rgba_tint[3]);
37- //cairo_fill_preserve (cr);
38- cairo_fill (cr);
39-
40- // create pattern in dot-context
41- /*cairo_set_operator (dots_cr, CAIRO_OPERATOR_CLEAR);
42- cairo_paint (dots_cr);
43- cairo_scale (dots_cr, 1.0f, 1.0f);
44- cairo_set_operator (dots_cr, CAIRO_OPERATOR_OVER);
45- cairo_set_source_rgba (dots_cr,
46- rgba_dot[0],
47- rgba_dot[1],
48- rgba_dot[2],
49- rgba_dot[3]);
50- cairo_rectangle (dots_cr, 0.0f, 0.0f, 1.0f, 1.0f);
51- cairo_fill (dots_cr);
52- cairo_rectangle (dots_cr, 2.0f, 2.0f, 1.0f, 1.0f);
53- cairo_fill (dots_cr);
54- dots_pattern = cairo_pattern_create_for_surface (dots_surf);*/
55-
56- // fill path of normal context with dot-pattern
57- /*cairo_set_operator (cr, CAIRO_OPERATOR_OVER);
58- cairo_set_source (cr, dots_pattern);
59- cairo_pattern_set_extend (dots_pattern, CAIRO_EXTEND_REPEAT);
60- cairo_fill_preserve (cr);
61- cairo_pattern_destroy (dots_pattern);
62- cairo_surface_destroy (dots_surf);
63- cairo_destroy (dots_cr);*/
64-
65- // draw highlight
66- /*cairo_set_operator (cr, CAIRO_OPERATOR_OVER);
67- hl_pattern = cairo_pattern_create_radial (hl_x,
68- hl_y,
69- 0.0f,
70- hl_x,
71- hl_y,
72- hl_size);
73- cairo_pattern_add_color_stop_rgba (hl_pattern,
74- 0.0f,
75- 1.0f,
76- 1.0f,
77- 1.0f,
78- 0.65f);
79- cairo_pattern_add_color_stop_rgba (hl_pattern, 1.0f, 1.0f, 1.0f, 1.0f, 0.0f);
80- cairo_set_source (cr, hl_pattern);
81- cairo_fill (cr);
82- cairo_pattern_destroy (hl_pattern);*/
83+ cairo_fill (cr);
84 }
85
86 void _setup (cairo_surface_t** surf,
87@@ -505,13 +451,6 @@
88 gint height,
89 gboolean negative)
90 {
91-// // create context
92-// if (outline)
93-// *surf = cairo_image_surface_create (CAIRO_FORMAT_ARGB32, width, height);
94-// else
95-// *surf = cairo_image_surface_create (CAIRO_FORMAT_A8, width, height);
96-// *cr = cairo_create (*surf);
97-
98 // clear context
99 cairo_scale (*cr, 1.0f, 1.0f);
100 if (outline)
101@@ -573,10 +512,6 @@
102 return;
103 }
104
105- //gint dynamic_size = height - 2*radius - 2*padding - anchor_height;
106- //gint upper_dynamic_size = upper_size;
107- //gint lower_dynamic_size = dynamic_size - upper_dynamic_size;
108-
109 if(upper_size >= 0)
110 {
111 if(upper_size > height - 2.0f * radius - anchor_height -2 * padding)
112@@ -757,7 +692,6 @@
113 _draw (cr, TRUE, line_width, rgba_shadow, FALSE, FALSE);
114 ctk_surface_blur (surf, blur_coeff);
115 compute_mask (cr);
116- //compute_outline (cr, line_width, rgba_line);
117 }
118
119 void compute_full_mask (