Merge lp:~canonical-dx-team/unity/unity.fix-685830 into lp:unity
Proposed by
Mirco Müller
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 867 | ||||
Proposed branch: | lp:~canonical-dx-team/unity/unity.fix-685830 | ||||
Merge into: | lp:unity | ||||
Diff against target: |
243 lines (+192/-2) 5 files modified
src/PanelIndicatorObjectEntryView.cpp (+1/-0) src/PanelStyle.cpp (+122/-0) src/PanelStyle.h (+47/-0) src/PanelView.cpp (+20/-2) tests/CMakeLists.txt (+2/-0) |
||||
To merge this branch: | bzr merge lp:~canonical-dx-team/unity/unity.fix-685830 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Neil J. Patel (community) | Needs Fixing | ||
Review via email: mp+43054@code.launchpad.net |
Description of the change
New style-handling class for the panel implemented as a singleton.
To post a comment you must log in.
It looks like you haven't yet hooked everything up so this merge proposal might be a bit premature. I'll comment on what I see anyway:
- It should be _panel_style not _panelStyle, same goes for anything else like that
- GetDefault(), if _panelStyle == NULL, then create a new one and return it, but if one is already around: return _panelStyle- >Reference( ); On the other end, the objects should grab panel style object on construction and then ->UnReference it on destruction.
- To be more C++, you should probably have:
nux::Color& GetBackgroundTop ()
etc, so you can do nux::Color top = style-> GetBackgroundTo p ();, which is cleaner
- Probably can rid of printfs?
- I think the PanelIndicatorO bjectEntryView bits still need to be hooked up
- Missing a "changed" signal so we can react to theme changes?