Code review comment for lp:~canonical-ci-engineering/uci-engine/nfss

Revision history for this message
Andy Doan (doanac) wrote :

On 06/30/2014 06:36 PM, Thomi Richards wrote:
>> + @unittest.skipUnless(have_mock, "No Mock available")
> When this gets deployed, we don't have mock installed, but pyramid scans the test packages to make the wsgi application. For that reason, packages need to be importable even if the test dependencies aren't available.

I thought mock is a part of python3? ie:

  python3 -c "import mock"

>> >=== added file 'nf-stats-service/setup.py'

>> >+requires = [
>> >+ 'mock==1.0.1',
> See note above...

If we do need this, we'll eventually have to include the actual
dependency in:

   lp:~canonical-ci-engineering/uci-engine/deps

once we figure out how to integrate this with tarmac testing.

« Back to merge proposal