Code review comment for lp:~canonical-ci-engineering/uci-engine/nfss

Revision history for this message
Francis Ginther (fginther) wrote :

This new service looks reasonable and I don't see anything that would prevent future integration into the uci-engine deployment. A few things to address in the future:
 - The api will need to be available via it's own namespace. So instead of an accessing it externally as /api/v1/foo, it would be /nfss/api/v1/foo. This can be done through the apache rewrite rules, so not a concern now.
 - Need to integrate with the uci-engine test infrastructure.
 - It would be nice to host the web-static content, but I understand that this is specific to this version of the deployment and can see why it would be appropriate to have this in the source tree (just like the charms are in the source tree).

I had one question regarding juju-deployer/nf-stats-service.yaml.tmpl in the inline comments.

review: Needs Information

« Back to merge proposal