Merge lp:~canonical-ca-hackers/ubuntu-recommender/fix-is-string-missing-attr into lp:ubuntu-recommender

[Łukasz Czyżykowski]

Fixes problem with outdated django-piston expecting _is_string attribute on the http response objects.

Fixes problem with outdated django-piston expecting _is_string attribute on the http response objects.

[Michael Nelson (michael.nelson)]

lukasz: Other than the s/possiblitlit/posibility/ +1

review: Approve

[lp:~canonical-ca-hackers/ubuntu-recommender/fix-is-string-missing-attr]

90. By Łukasz Czyżykowski on 2013-08-14

Typo fix

=== modified file 'src/recommender/api/handlers.py'
--- src/recommender/api/handlers.py	2013-02-18 19:42:50 +0000
+++ src/recommender/api/handlers.py	2013-08-14 12:20:34 +0000
@@ -53,6 +53,13 @@
     ImplicitFeedbackForm,
 )
 
+# django-piston (outdated bit of software) expects those attributes to
+# determine if the resonse content is iterator or not. Here we never
+# use that possibility, so hardcoding the attribute.
+HttpResponse._is_string = True
+HttpResponseNotFound._is_string = True
+HttpResponseBadRequest._is_string = True
+
 
 def get_top_rated_apps(limit):
     return [{'package_name': p.name, 'rating': p.wilson_score}

=== removed file 'src/recommender/management/commands/runserver.py'
--- src/recommender/management/commands/runserver.py	2013-02-22 16:47:48 +0000
+++ src/recommender/management/commands/runserver.py	1970-01-01 00:00:00 +0000
@@ -1,20 +0,0 @@
-# Slightly customized version of Django's runserver command
-# that runs ubuntu-recommender's wsgi stack.
-
-from optparse import make_option
-from django.core.management.commands.runserver import BaseRunserverCommand
-from django.core.servers.basehttp import AdminMediaHandler
-
-
-class Command(BaseRunserverCommand):
-    option_list = BaseRunserverCommand.option_list + (
-        make_option(
-            '--adminmedia', dest='admin_media_path', default='',
-            help='Specifies the directory from which to serve admin media.'),
-    )
-
-    def get_handler(self, *args, **options):
-        """Serves admin media like old-school (deprecation pending)."""
-        from recommender.wsgi import make_app
-        handler = make_app()
-        return AdminMediaHandler(handler, options.get('admin_media_path', ''))