Merge lp:~canonical-ca-hackers/ubuntu-recommender/933884-delete-old-recommendations into lp:ubuntu-recommender

[Łukasz Czyżykowski]

Added recommendation_cleanup management command.

Overview
========
This branch adds a management command to clean up old Recommendation objects which doesn't have any feedback. By default, recommendation created more than 30 days ago are deleted, but this can be specified on the command line.

$ python manage.py recommendation_cleanup [30]

[Michael Nelson (michael.nelson)]

review: Approve

=== added file 'src/recommender/management/commands/recommendation_cleanup.py'
--- src/recommender/management/commands/recommendation_cleanup.py	1970-01-01 00:00:00 +0000
+++ src/recommender/management/commands/recommendation_cleanup.py	2012-03-02 15:02:42 +0000
@@ -0,0 +1,57 @@
+#   -*- coding: utf-8 -*-
+#   This file is part of the Ubuntu Recommender
+#   Copyright (C) 2011-2012 Canonical Ltd.
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+from __future__ import absolute_import
+
+__metaclass__ = type
+__all__ = ['Command']
+
+import logging
+
+from datetime import date, timedelta
+
+from django.core.management.base import BaseCommand
+
+from recommender.models import AppRecommendation, UserRecommendation
+
+
+class Command(BaseCommand):
+
+    args = "<optional number of days>"
+    help = "Removes staled recommendation objects."
+
+    def handle(self, *args, **options):
+        try:
+            days = float(args[0])
+        except (IndexError, ValueError):
+            days = 30
+
+        log = logging.getLogger('recommender.recommendation_cleanup')
+        month_ago = date.today() - timedelta(days=days)
+
+        log.info("Cleaning up old AppRecommendations")
+        to_delete_qs = AppRecommendation.objects.filter(
+            date_created__lt=month_ago, feedback__isnull=True)
+        deleted_count = to_delete_qs.count()
+        to_delete_qs.delete()
+        log.debug("Removed %d AppRecommendation objects", deleted_count)
+
+        log.info("Cleaning up old UserRecommendation")
+        to_delete_qs = UserRecommendation.objects.filter(
+            date_created__lt=month_ago, feedback__isnull=True)
+        deleted_count = to_delete_qs.count()
+        to_delete_qs.delete()
+        log.debug("Removed %d UserRecommendation objects", deleted_count)

=== modified file 'src/recommender/tests/test_commands.py'
--- src/recommender/tests/test_commands.py	2012-03-02 13:12:27 +0000
+++ src/recommender/tests/test_commands.py	2012-03-02 15:02:42 +0000
@@ -24,11 +24,12 @@
     'ImportRnRDataTestCase',
     'SlopeOneBootstrapTestCase',
     'SlopeOneUpdateTestCase',
+    'RecommendationCleanupTestCase',
 ]
 
 import sys
 from cStringIO import StringIO
-from datetime import date
+from datetime import date, datetime, timedelta
 
 from django.core.management import call_command
 from django_factory import (
@@ -42,6 +43,8 @@
     PersonIdentification,
     Package,
     SlopeOneFrequency,
+    AppRecommendation,
+    UserRecommendation,
 )
 from recommender.management.commands.import_rnr_data import (
     RatingsAndReviewsAPI,
@@ -199,3 +202,41 @@
         # Not 4/3 because user_2 hasn't rated item_3
         self.assertEqual(2,
             SlopeOneFrequency.objects.filter(package_1=item_4).count())
+
+
+class RecommendationCleanupTestCase(TransactionTestCase):
+
+    def test_running_command_removes_stale_app_recommendations(self):
+        month_ago = datetime.utcnow() - timedelta(days=31)
+        self.factory.make(3, AppRecommendation,
+                          date_created=month_ago)
+        self.factory.make_one(AppRecommendation, feedback=1,
+                          date_created=month_ago)
+
+        self.factory.make_one(AppRecommendation)
+
+        call_command('recommendation_cleanup')
+
+        self.assertEqual(2, AppRecommendation.objects.count())
+
+    def test_running_command_removes_stale_user_recommendations(self):
+        month_ago = datetime.utcnow() - timedelta(days=31)
+        self.factory.make(3, UserRecommendation,
+                          date_created=month_ago)
+        self.factory.make_one(UserRecommendation, feedback=1,
+                          date_created=month_ago)
+
+        self.factory.make_one(UserRecommendation)
+
+        call_command('recommendation_cleanup')
+
+        self.assertEqual(2, UserRecommendation.objects.count())
+
+    def test_running_command_takes_into_account_passed_number_of_days(self):
+        self.factory.make_one(
+            AppRecommendation,
+            date_created=(datetime.utcnow() - timedelta(days=11)))
+
+        call_command('recommendation_cleanup', 10)
+
+        self.assertEqual(0, AppRecommendation.objects.count())