Merge bootstack-ops:logging into bootstack-ops:master

[Joe Guo]

juju_bundle_export.py: use logging for diagnosis info

currenly, both diagnosis info and sanitized bundle yaml are printed to stdout.

this patch uses logging for diagnosis info, which will print to stderr instead of stdout.

This will be helpful to exclude diagnosis info when we redirect the output to file with `>` or `tee`.

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Xav Paice (xavpaice)]

LGTM, tests OK

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision 17f147128087a6c1d63a282fde480b74b1c95677

diff --git a/bootstack-ops/juju_bundle_export.py b/bootstack-ops/juju_bundle_export.py
index 8f1845d..d64a7aa 100755
--- a/bootstack-ops/juju_bundle_export.py
+++ b/bootstack-ops/juju_bundle_export.py
@@ -27,6 +27,11 @@ import sys
 import yaml
 import argparse
 import math
+import logging
+
+LOG_FORMAT = '%(asctime)s - %(levelname)-9s - %(module)s - %(message)s'
+logging.basicConfig(format=LOG_FORMAT)
+log = logging.getLogger(__name__)
 
 
 MASK_KEYS = ('(.*(ssl-public-key|ssl[_-](ca|cert|key)|secret|password|'
@@ -78,7 +83,7 @@ class Bundle(object):
     def get_common_bundle(self):
         # return the common info only
         if self.__check_for_entropy_in_dict(self.common_bundle):
-            print('Some entropy was found in the common bundle')
+            log.warning('Some entropy was found in the common bundle')
         common_bundle = self.common_bundle
         return common_bundle
 
@@ -132,18 +137,18 @@ class Bundle(object):
                     if b64Entropy > 3.8:
                         stringsFound.append(string)
                         entropy_found = True
-                        print('WARNING! Entropy found in string '
+                        log.warning('WARNING! Entropy found in string '
                               '"{}"'.format(string))
                 for string in hex_strings:
                     hexEntropy = self.__shannon_entropy(string, HEX_CHARS)
                     if hexEntropy > 3:
                         stringsFound.append(string)
                         entropy_found = True
-                        print('WARNING! Entropy found in string '
+                        log.warning('WARNING! Entropy found in string '
                               '"{}"'.format(string))
 
         if len(stringsFound) != 0:
-            print('ERROR!!! Check output file for entropy warnings, '
+            log.error('ERROR!!! Check output file for entropy warnings, '
                   'may not be secure.')
 
         return entropy_found