Merge bootstack-ops:prometheus-sprint into bootstack-ops:master

Proposed by JuanJo Ciarlante
Status: Rejected
Rejected by: Benjamin Kaehne
Proposed branch: bootstack-ops:prometheus-sprint
Merge into: bootstack-ops:master
Diff against target: 177 lines (+114/-28)
3 files modified
Makefile (+2/-1)
README.md (+7/-2)
ops-bundle.yaml (+105/-25)
Reviewer Review Type Date Requested Status
Alvaro Uria (community) lgtm Approve
Review via email: mp+315219@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alvaro Uria (aluria) :
review: Approve (lgtm)
Revision history for this message
Benjamin Kaehne (ben-kaehne) :
bootstack-ops:prometheus-sprint updated
f417fc4... by JuanJo Ciarlante

Use bootstack-CUSTOMER

Revision history for this message
JuanJo Ciarlante (jjo) :
Revision history for this message
Benjamin Kaehne (ben-kaehne) wrote :

Looks good to merge. Please squash first.

Unmerged commits

f417fc4... by JuanJo Ciarlante

Use bootstack-CUSTOMER

48f7672... by JuanJo Ciarlante

re-Fix README.md

fcbe8bd... by JuanJo Ciarlante

Fix README.md

7fc36b4... by JuanJo Ciarlante

[jjo] add reporting stack (prometheus + grafana + alertmanager) to ops-bundle.yaml

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Makefile b/Makefile
2index 2952592..bc42ed3 100644
3--- a/Makefile
4+++ b/Makefile
5@@ -2,4 +2,5 @@
6 PYTHON := /usr/bin/env python
7
8 lint:
9- yamllint -c .yamllint.config ops-bundle.yaml
10+ test -x /usr/bin/yamllint && yamllint -c .yamllint.config ops-bundle.yaml || true
11+ python -c 'import yaml,sys;yaml.load(sys.stdin)' < ops-bundle.yaml
12diff --git a/README.md b/README.md
13index 81c4f94..3e7fb67 100644
14--- a/README.md
15+++ b/README.md
16@@ -10,10 +10,15 @@ make lint
17
18 # Contributing Quickstart Guide
19
20-git clone git+ssh://git.launchpad.net/~canonical-bootstack/+git/opsbundle
21+git clone git+ssh://git.launchpad.net/~canonical-bootstack/bootstack-ops/+git/bootstack-ops
22+cd bootstack-ops
23
24 git checkout -b myfeature
25
26-git push git+ssh://git.launchpad.net/~{YOUR-LP-ACCOUNT}/canonical-bootstack/+git/opsbundle mybranch
27+<... hack ...>
28+
29+git commit ...
30+
31+git push origin myfeature
32
33 Create a MR on LP UI.
34diff --git a/ops-bundle.yaml b/ops-bundle.yaml
35index 6994893..3321579 100644
36--- a/ops-bundle.yaml
37+++ b/ops-bundle.yaml
38@@ -1,5 +1,12 @@
39 config: &OPS_CLUSTER ["lxc:infra=0", "lxc:infra=1", "lxc:infra=2"]
40
41+# reporting: prometheus + grafana + alertmanager stack
42+# Because snaps fail inside LXC lp#1611078 (xenial/lxd) lp#1582394 (xenial/lxc),
43+# we need a KVM, then we smoosh all services into.
44+config: &REPORTING_SVC_TO "reporting=0"
45+config: &REGION bootstack-CUSTOMER
46+config: &NAGIOS_CONTEXT bootstack-CUSTOMER
47+
48 logging:
49 services:
50 elasticsearch:
51@@ -16,28 +23,101 @@ logging:
52
53 rsyslog-elasticsearch:
54 charm: rsyslog-elasticsearch
55- relations:
56- - [rsyslog-elasticsearch, elasticsearch]
57- - [rsyslog-elasticsearch, ceilometer]
58- - [rsyslog-elasticsearch, cinder]
59- - [rsyslog-elasticsearch, glance]
60- - [rsyslog-elasticsearch, glance-simplestreams-sync]
61- - [rsyslog-elasticsearch, heat]
62- - [rsyslog-elasticsearch, keystone]
63- - [rsyslog-elasticsearch, landscape]
64- - [rsyslog-elasticsearch, landscape-apache]
65- - [rsyslog-elasticsearch, landscape-haproxy]
66- - [rsyslog-elasticsearch, landscape-msg]
67- - [rsyslog-elasticsearch, landscape-postgresql]
68- - [rsyslog-elasticsearch, mongodb]
69- - [rsyslog-elasticsearch, mysql]
70- - [rsyslog-elasticsearch, ncc-memcached]
71- - [rsyslog-elasticsearch, neutron-api]
72- - [rsyslog-elasticsearch, neutron-gateway]
73- - [rsyslog-elasticsearch, nova-cloud-controller]
74- - [rsyslog-elasticsearch, openstack-dashboard]
75- - [rsyslog-elasticsearch, rabbitmq-server]
76- - [rsyslog-elasticsearch, swift-proxy]
77- - [rsyslog-elasticsearch, ubuntu-nagios]
78- - [rsyslog-elasticsearch, infra]
79- - [rsyslog-elasticsearch, os-hosts]
80+ relations:
81+ - [rsyslog-elasticsearch, elasticsearch]
82+ - [rsyslog-elasticsearch, ceilometer]
83+ - [rsyslog-elasticsearch, cinder]
84+ - [rsyslog-elasticsearch, glance]
85+ - [rsyslog-elasticsearch, glance-simplestreams-sync]
86+ - [rsyslog-elasticsearch, heat]
87+ - [rsyslog-elasticsearch, keystone]
88+ - [rsyslog-elasticsearch, landscape]
89+ - [rsyslog-elasticsearch, landscape-apache]
90+ - [rsyslog-elasticsearch, landscape-haproxy]
91+ - [rsyslog-elasticsearch, landscape-msg]
92+ - [rsyslog-elasticsearch, landscape-postgresql]
93+ - [rsyslog-elasticsearch, mongodb]
94+ - [rsyslog-elasticsearch, mysql]
95+ - [rsyslog-elasticsearch, ncc-memcached]
96+ - [rsyslog-elasticsearch, neutron-api]
97+ - [rsyslog-elasticsearch, neutron-gateway]
98+ - [rsyslog-elasticsearch, nova-cloud-controller]
99+ - [rsyslog-elasticsearch, openstack-dashboard]
100+ - [rsyslog-elasticsearch, rabbitmq-server]
101+ - [rsyslog-elasticsearch, swift-proxy]
102+ - [rsyslog-elasticsearch, ubuntu-nagios]
103+ - [rsyslog-elasticsearch, infra]
104+ - [rsyslog-elasticsearch, os-hosts]
105+
106+# reporting: create a KVM with maas' tag=reporting as reporting/0
107+bootstack-reporting-stage0:
108+ inherits: [bootstack-stage2-complete]
109+ services:
110+ reporting:
111+ charm: ubuntu
112+ constraints: tags=reporting
113+
114+# reporting: smoosh prometheus + grafana + alertmanager into reporting/0
115+bootstack-reporting:
116+ inherits: [bootstack-reporting-stage0]
117+ override:
118+ nagios_context: *NAGIOS_CONTEXT
119+ nagios_servicegroups: *REGION
120+ services:
121+ prometheus:
122+ #charm: cs:~prometheus-charmers/prometheus
123+ charm: prometheus
124+ num_units: 1
125+ to: *REPORTING_SVC_TO
126+ options:
127+ ## XXX(jjo): depends on customer setup (maas-proxy) ->
128+ snap_proxy: http://10.76.12.1:8000/
129+ ## XXX(jjo): need to charm openstack-exporter, for now point to the manually deployed install:
130+ ## https://github.com/CanonicalLtd/prometheus-openstack-exporter
131+ static-targets: 'localhost:9183'
132+ grafana:
133+ #charm: cs:~prometheus-charmers/grafana
134+ charm: grafana
135+ num_units: 1
136+ to: *REPORTING_SVC_TO
137+ options:
138+ ## XXX: default deb archive at packagecloud.io redirects to:
139+ ## packagecloud-repositories.s3.dualstack.us-west-1.amazonaws.com
140+ install_file: https://grafanarel.s3.amazonaws.com/builds/grafana-data_4.1.1-1484211277_amd64.deb
141+# ops-agents.yaml would need to set ->
142+# datasources: 'prometheus,BootStack Prometheus,proxy,http://172.12.x.x:9090,,'
143+ ## XXX: must go to secrets.yaml
144+ admin_password: admin
145+ prometheus-alertmanager:
146+ #charm: cs:~prometheus-charmers/trusty/prometheus-alertmanager
147+ charm: prometheus-alertmanager
148+ to: *REPORTING_SVC_TO
149+ relations:
150+ - ["grafana:grafana-source", "prometheus:grafana-source"]
151+ - ["prometheus:alertmanager-service", "prometheus-alertmanager:alertmanager-service"]
152+
153+# reporting: deploy telegraf subordinate into every metal or containerized node,
154+# XXX: below stanza will need to be autogenerated (ala landscape-client) against:
155+# - metals (= os-hosts)
156+# - all LXC'd services
157+
158+bootstack-reporting-agents:
159+ inherits: [bootstack-reporting]
160+ services:
161+ telegraf:
162+ #charm: cs:telegraf
163+ charm: telegraf
164+ options:
165+# prometheus_output_port: "9103"
166+# extra_plugins: |
167+# [[inputs.bcache]]
168+# [[inputs.conntrack]]
169+# [[inputs.sysstat]]
170+# sadc_path = "/usr/lib/sysstat/sadc"
171+# activities = ["DISK"]
172+
173+ relations:
174+ - [ telegraf, os-hosts ]
175+ - [ "prometheus:target", "telegraf:prometheus-client"]
176+
177+# vim: et si sw=4 ts=4

Subscribers

People subscribed via source and target branches

to all changes: