Code review comment for lp:~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

> Guewen,
>
> Changes about sale and sale order line (_prepare methods on sale order, field
> location_id on sale order line, sale views and sale tests)
> are already in sale_sourced_by_line addon proposed here :
> https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-
> sale_sourced_and_stock_ownership/+merge/194527
>
> It seems to me that the best location is sale_sourced_by_line because pointed
> changes concern sale objects.
>
> What do you think about it?
>
> Regards,
>
> Romain

Hello Romain,

Despite my name on the revision, I'm not the author of the rev. 37. I don't understand exactly how does work this extraction script regarding the authorship... Well, though I'm the author of the original module, and the thing you point is correct: the sale.py module is not supposed to exist (not imported BTW), it has been removed in the original module. I guess this is a extraction error.

« Back to merge proposal