Merge lp:~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe into lp:stock-logistic-warehouse

Proposed by Alexandre Fayolle - camptocamp
Status: Needs review
Proposed branch: lp:~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe
Merge into: lp:stock-logistic-warehouse
Diff against target: 126 lines (+100/-1)
4 files modified
stock_location_ownership/__openerp__.py (+7/-1)
stock_location_ownership/i18n/en.po (+31/-0)
stock_location_ownership/i18n/fr.po (+31/-0)
stock_location_ownership/i18n/stock_location_ownership.pot (+31/-0)
To merge this branch: bzr merge lp:~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp Needs Resubmitting
Ana Juaristi Olalde (community) Approve
Sandy Carter (http://www.savoirfairelinux.com) grammar Needs Fixing
Pedro Manuel Baeza code review Approve
Yannick Vaucher @ Camptocamp Approve
Review via email: mp+210859@code.launchpad.net

Description of the change

stock_location_ownership: add missing pot file, improve module description.

To post a comment you must log in.
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Thanks LGTM

review: Approve
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Thank you very much for expand the description!

Regards.

review: Approve (code review)
Revision history for this message
Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote :

Grammar mistakes in the description

l.11 instances should be plural
This is useful for instance
This is useful for instances

l.12 comma after case
In which case a possible workflow
In which case, a possible workflow

l.12 run on sentence, consider breaking into two
In which case, a possible workflow
could be that the company is allowed to use that stock, but this would generate
a purchase order for the real owner of the stock, with or without direct
delivery.
In which case, a possible workflow
could be that the company is allowed to use that stock. This would generate
a purchase order for the real owner of the stock, with or without direct
delivery.

review: Needs Fixing (grammar)
Revision history for this message
Ana Juaristi Olalde (ajuaristio) wrote :

Thanks LGTM

review: Approve
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

The source code management for this project has been moved to https://github.com/OCA/stock-logistics-warehouse

Could you resubmit this MP on the new site?

review: Needs Resubmitting

Unmerged revisions

36. By Alexandre Fayolle - camptocamp on 2014-03-13

[IMP] stock_location_ownership: improve addon description

35. By Alexandre Fayolle - camptocamp on 2014-03-13

[IMP] stock_location_ownership: add pot file and french translation

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'stock_location_ownership/__openerp__.py'
2--- stock_location_ownership/__openerp__.py 2013-08-06 15:07:18 +0000
3+++ stock_location_ownership/__openerp__.py 2014-03-13 16:59:31 +0000
4@@ -31,7 +31,13 @@
5 Stock Location Ownership
6 ========================
7
8-Adds an ownership on the stock locations
9+Adds an ownership on the stock locations.
10+
11+This is useful for instance when some locations in a warehouse are used to hold
12+products which do not belong to the company. In which case a possible workflow
13+could be that the company is allowed to use that stock, but this would generate
14+a purchase order for the real owner of the stock, with or without direct
15+delivery.
16 """,
17 'depends': ['stock',
18 ],
19
20=== added file 'stock_location_ownership/i18n/en.po'
21--- stock_location_ownership/i18n/en.po 1970-01-01 00:00:00 +0000
22+++ stock_location_ownership/i18n/en.po 2014-03-13 16:59:31 +0000
23@@ -0,0 +1,31 @@
24+# Translation of OpenERP Server.
25+# This file contains the translation of the following modules:
26+#
27+msgid ""
28+msgstr ""
29+"Project-Id-Version: OpenERP Server 7.0\n"
30+"Report-Msgid-Bugs-To: \n"
31+"POT-Creation-Date: 2014-03-13 16:49+0000\n"
32+"PO-Revision-Date: 2014-03-13 16:44+0000\n"
33+"Last-Translator: <>\n"
34+"Language-Team: \n"
35+"Language: \n"
36+"MIME-Version: 1.0\n"
37+"Content-Type: text/plain; charset=UTF-8\n"
38+"Content-Transfer-Encoding: \n"
39+"Plural-Forms: \n"
40+
41+#. module: stock_location_ownership
42+#: field:stock.location,owner_id:0
43+msgid "Owner"
44+msgstr "Owner"
45+
46+#. module: stock_location_ownership
47+#: help:stock.location,owner_id:0
48+msgid "Owner of the location if different from the company or address."
49+msgstr "Owner of the location if different from the company or address."
50+
51+#. module: stock_location_ownership
52+#: model:ir.model,name:stock_location_ownership.model_stock_location
53+msgid "Location"
54+msgstr "Location"
55
56=== added file 'stock_location_ownership/i18n/fr.po'
57--- stock_location_ownership/i18n/fr.po 1970-01-01 00:00:00 +0000
58+++ stock_location_ownership/i18n/fr.po 2014-03-13 16:59:31 +0000
59@@ -0,0 +1,31 @@
60+# Translation of OpenERP Server.
61+# This file contains the translation of the following modules:
62+#
63+msgid ""
64+msgstr ""
65+"Project-Id-Version: OpenERP Server 7.0\n"
66+"Report-Msgid-Bugs-To: \n"
67+"POT-Creation-Date: 2014-03-13 16:49+0000\n"
68+"PO-Revision-Date: 2014-03-13 17:51+0100\n"
69+"Last-Translator: <>\n"
70+"Language-Team: \n"
71+"Language: \n"
72+"MIME-Version: 1.0\n"
73+"Content-Type: text/plain; charset=UTF-8\n"
74+"Content-Transfer-Encoding: \n"
75+"Plural-Forms: \n"
76+
77+#. module: stock_location_ownership
78+#: field:stock.location,owner_id:0
79+msgid "Owner"
80+msgstr "Propriétaire"
81+
82+#. module: stock_location_ownership
83+#: help:stock.location,owner_id:0
84+msgid "Owner of the location if different from the company or address."
85+msgstr "Propriétaire de l'emplacement, si différent de la société"
86+
87+#. module: stock_location_ownership
88+#: model:ir.model,name:stock_location_ownership.model_stock_location
89+msgid "Location"
90+msgstr "Emplacement"
91
92=== added file 'stock_location_ownership/i18n/stock_location_ownership.pot'
93--- stock_location_ownership/i18n/stock_location_ownership.pot 1970-01-01 00:00:00 +0000
94+++ stock_location_ownership/i18n/stock_location_ownership.pot 2014-03-13 16:59:31 +0000
95@@ -0,0 +1,31 @@
96+# Translation of OpenERP Server.
97+# This file contains the translation of the following modules:
98+#
99+msgid ""
100+msgstr ""
101+"Project-Id-Version: OpenERP Server 7.0\n"
102+"Report-Msgid-Bugs-To: \n"
103+"POT-Creation-Date: 2014-03-13 16:49+0000\n"
104+"PO-Revision-Date: 2014-03-13 17:50+0100\n"
105+"Last-Translator: <>\n"
106+"Language-Team: \n"
107+"Language: \n"
108+"MIME-Version: 1.0\n"
109+"Content-Type: text/plain; charset=UTF-8\n"
110+"Content-Transfer-Encoding: \n"
111+"Plural-Forms: \n"
112+
113+#. module: stock_location_ownership
114+#: field:stock.location,owner_id:0
115+msgid "Owner"
116+msgstr ""
117+
118+#. module: stock_location_ownership
119+#: help:stock.location,owner_id:0
120+msgid "Owner of the location if different from the company or address."
121+msgstr ""
122+
123+#. module: stock_location_ownership
124+#: model:ir.model,name:stock_location_ownership.model_stock_location
125+msgid "Location"
126+msgstr ""

Subscribers

People subscribed via source and target branches