Merge lp:~camptocamp/stock-logistic-report/7.0-replace-print-actions-mdh into lp:stock-logistic-report

Proposed by Matthieu Dietrich @ camptocamp
Status: Rejected
Rejected by: Leonardo Pistone
Proposed branch: lp:~camptocamp/stock-logistic-report/7.0-replace-print-actions-mdh
Merge into: lp:stock-logistic-report
Diff against target: 15 lines (+4/-1)
1 file modified
stock_picking_webkit/stock_view.xml (+4/-1)
To merge this branch: bzr merge lp:~camptocamp/stock-logistic-report/7.0-replace-print-actions-mdh
Reviewer Review Type Date Requested Status
Leonardo Pistone Approve
Guewen Baconnier @ Camptocamp code review Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+225126@code.launchpad.net

Commit message

[IMP] modify both buttons 'Print Delivery Order' to use the Webkit report

Description of the change

This is an improvement of the fix introduced in lp:~camptocamp/stock-logistic-report/7.0-button-print-delivery-order.
The issue was that XPath in OpenERP replaces only the first element found, so the "Print Delivery Order" button for the 'done' state still used the old report instead of the new one.

Now, both buttons are matched and replaced.

Regards,
Matthieu Dietrich

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM

review: Approve (code review)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Thanks

review: Approve (code review)
Revision history for this message
Leonardo Pistone (lepistone) wrote :

lgtm

review: Approve
Revision history for this message
Leonardo Pistone (lepistone) wrote :

I moved that to https://github.com/OCA/stock-logistics-reporting/pull/2

As it was approved here, I will merge it as soon as the tests pass.

Thanks!

Unmerged revisions

10. By Matthieu Dietrich @ camptocamp

[FIX] replace both Print buttons with the new action

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'stock_picking_webkit/stock_view.xml'
2--- stock_picking_webkit/stock_view.xml 2013-12-23 14:06:02 +0000
3+++ stock_picking_webkit/stock_view.xml 2014-07-01 09:18:19 +0000
4@@ -6,7 +6,10 @@
5 <field name="model">stock.picking.out</field>
6 <field name="inherit_id" ref="delivery.view_delivery_order_inherit_stock"/>
7 <field name="arch" type="xml">
8- <xpath expr="/form/header//button[@string='Print Delivery Order']" position="attributes">
9+ <xpath expr="/form/header//button[@string='Print Delivery Order' and @states='confirmed,assigned']" position="attributes">
10+ <attribute name="name">%(stock.report_picking_list_out)d</attribute>
11+ </xpath>
12+ <xpath expr="/form/header//button[@string='Print Delivery Order' and @states='done']" position="attributes">
13 <attribute name="name">%(stock.report_picking_list_out)d</attribute>
14 </xpath>
15 </field>

Subscribers

People subscribed via source and target branches