Merge lp:~camptocamp/stock-logistic-report/7.0-button-print-delivery-order into lp:stock-logistic-report

[Guewen Baconnier @ Camptocamp]

The stock_picking_webkit aims to replace the RML report, but the button to print the delivery orders still print the RML report.

Change the action of the button to print the new one.

[Leonardo Pistone (lepistone)]

LGTM, thanks

review: Approve (code review)

[Pedro Manuel Baeza (pedro.baeza)]

Seems OK to me, but I wonder if it's not better to simply replace the report definition instead, because if there are other custom modules that use that report, they will still use the old report.

Regards.

review: Needs Information

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> Seems OK to me, but I wonder if it's not better to simply replace the report
> definition instead, because if there are other custom modules that use that
> report, they will still use the old report.
>
> Regards.

This was done already in the module, but on the stock picking's report (stock.report_picking_list_out), and the button points to the delivery picking's report.
I fear the side effects on existing databases if we change that now.

[Pedro Manuel Baeza (pedro.baeza)]

OK then, Guewen.

Thank you.

Regards.

review: Approve

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

review: Approve (code review, no tests)

=== modified file 'stock_picking_webkit/__openerp__.py'
--- stock_picking_webkit/__openerp__.py	2013-12-13 04:40:56 +0000
+++ stock_picking_webkit/__openerp__.py	2013-12-23 14:07:03 +0000
@@ -35,7 +35,9 @@
     'author': 'Camptocamp',
     'website': 'http://www.openerp.com',
     'depends': ['base', 'report_webkit', 'base_headers_webkit', 'stock', 'delivery'],
-    'data': ['report.xml'],
+    'data': ['report.xml',
+             'stock_view.xml',
+             ],
     'installable': True,
     'auto_install': False,
 }

=== added file 'stock_picking_webkit/stock_view.xml'
--- stock_picking_webkit/stock_view.xml	1970-01-01 00:00:00 +0000
+++ stock_picking_webkit/stock_view.xml	2013-12-23 14:07:03 +0000
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data noupdate="0">
+        <record id="view_picking_out_form" model="ir.ui.view">
+            <field name="name">stock.picking.out.form</field>
+            <field name="model">stock.picking.out</field>
+            <field name="inherit_id" ref="delivery.view_delivery_order_inherit_stock"/>
+            <field name="arch" type="xml">
+                <xpath expr="/form/header//button[@string='Print Delivery Order']" position="attributes">
+                    <attribute name="name">%(stock.report_picking_list_out)d</attribute>
+                </xpath>
+            </field>
+        </record>
+    </data>
+</openerp>