Merge lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers into lp:stock-logistic-flows

Proposed by Romain Deheele - Camptocamp
Status: Needs review
Proposed branch: lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers
Merge into: lp:stock-logistic-flows
Diff against target: 33 lines (+6/-3)
1 file modified
stock_cancel/stock_view.xml (+6/-3)
To merge this branch: bzr merge lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp Needs Resubmitting
Pedro Manuel Baeza code review Needs Information
Review via email: mp+223529@code.launchpad.net

Description of the change

Hello,

stock_cancel addon introduces a button named "re-open" that allows to re-open a done or canceled picking.
It seems that in practical it's safer to restrict this feature to warehouse managers.
What do you think about it?

Feel free to share your opinion,

Romain

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Well, I think that this function is both used by warehouse managers and users: I see not much sense to contact a manager to reopen one picking canceled by error. But maybe for done pickings, re-open task is more sensible.

What do you think?

Regards.

review: Needs Information (code review)
Revision history for this message
Romain Deheele - Camptocamp (romaindeheele) wrote :

Your remark makes sense about canceled pickings.
Maybe it's better to let freedom to developers to specify access rights/visibility according to the context.

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

The source code management for this project has been moved to https://github.com/OCA/stock-logistics-workflow

Could you resubmit this MP on the new site?

review: Needs Resubmitting

Unmerged revisions

61. By Romain Deheele - Camptocamp on 2014-06-18

[UPD] restrict reopen button to warehouse managers

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'stock_cancel/stock_view.xml'
2--- stock_cancel/stock_view.xml 2013-06-05 14:38:18 +0000
3+++ stock_cancel/stock_view.xml 2014-06-18 09:46:16 +0000
4@@ -8,7 +8,8 @@
5 <field name="inherit_id" ref="stock.view_picking_out_form"/>
6 <field name="arch" type="xml">
7 <button name="%(stock.act_stock_return_picking)d" position="after">
8- <button name="action_revert_done" string="Reopen" states="done,cancel" type="object" icon="gtk-cancel" confirm="Are you sure you want to reopen this stock picking?"/>
9+ <button name="action_revert_done" string="Reopen" states="done,cancel" type="object" icon="gtk-cancel" confirm="Are you sure you want to reopen this stock picking?"
10+ groups="stock.group_stock_manager"/>
11 </button>
12 </field>
13 </record>
14@@ -19,7 +20,8 @@
15 <field name="inherit_id" ref="stock.view_picking_in_form"/>
16 <field name="arch" type="xml">
17 <button name="%(stock.act_stock_return_picking)d" position="after">
18- <button name="action_revert_done" string="Reopen" states="done,cancel" type="object" icon="gtk-cancel" confirm="Are you sure you want to reopen this stock picking?"/>
19+ <button name="action_revert_done" string="Reopen" states="done,cancel" type="object" icon="gtk-cancel" confirm="Are you sure you want to reopen this stock picking?"
20+ groups="stock.group_stock_manager"/>
21 </button>
22 </field>
23 </record>
24@@ -30,7 +32,8 @@
25 <field name="inherit_id" ref="stock.view_picking_form"/>
26 <field name="arch" type="xml">
27 <button name="%(stock.action_stock_invoice_onshipping)d" position="after">
28- <button name="action_revert_done" string="Reopen" states="done,cancel" type="object" icon="gtk-cancel" confirm="Are you sure you want to reopen this stock picking?"/>
29+ <button name="action_revert_done" string="Reopen" states="done,cancel" type="object" icon="gtk-cancel" confirm="Are you sure you want to reopen this stock picking?"
30+ groups="stock.group_stock_manager"/>
31 </button>
32 </field>
33 </record>

Subscribers

People subscribed via source and target branches