Merge lp:~camptocamp/server-env-tools/7.0-fix-1302500 into lp:~server-env-tools-core-editors/server-env-tools/7.0

Proposed by Yannick Vaucher @ Camptocamp
Status: Merged
Merged at revision: 71
Proposed branch: lp:~camptocamp/server-env-tools/7.0-fix-1302500
Merge into: lp:~server-env-tools-core-editors/server-env-tools/7.0
Diff against target: 11 lines (+1/-0)
1 file modified
web_context_tunnel/static/src/js/context_tunnel.js (+1/-0)
To merge this branch: bzr merge lp:~camptocamp/server-env-tools/7.0-fix-1302500
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Approve
Raphaël Valyi - http://www.akretion.com Approve
Holger Brunn (Therp) code review Approve
Review via email: mp+214250@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Luis Felipe Miléo - http://www.kmee.com.br (mileo) wrote :

LGTM.

Thanks

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

Won't you lose the field's context here if there's one set?

review: Needs Information
70. By Yannick Vaucher @ Camptocamp

remove set_eval_context as initialized in init

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

@Holger Context elements are passed in CompoundContext init with v_context.

From this function, we need to provide a CompundContext or it will raise an error when trying to use add method on the returned value.

I removed the set_eval_context as it isn't needed. `this.__eval_context` is already set to null in init function.

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

Thanks Yannick!

review: Approve (code review)
Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

Thanks for spotting this Yannick

review: Approve
Revision history for this message
Luis Felipe Miléo - http://www.kmee.com.br (mileo) wrote :

@rvalyi

That was the "web" bug that I had spoken last week hangout

[]s

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'web_context_tunnel/static/src/js/context_tunnel.js'
2--- web_context_tunnel/static/src/js/context_tunnel.js 2013-12-26 16:23:00 +0000
3+++ web_context_tunnel/static/src/js/context_tunnel.js 2014-04-07 13:38:15 +0000
4@@ -17,6 +17,7 @@
5 }
6 if (!v_context) {
7 v_context = (this.field || {}).context || {};
8+ v_context = new instance.web.CompoundContext(v_context);
9 }
10 return v_context;
11 };