Merge lp:~camptocamp/sale-wkfl/7.0-avoid_sale_lines_dropshipping_make_to_order_without_supplierinfos-rde into lp:~sale-core-editors/sale-wkfl/7.0
Proposed by
Romain Deheele - Camptocamp
Status: | Merged |
---|---|
Approved by: | Yannick Vaucher @ Camptocamp |
Approved revision: | 32 |
Merged at revision: | 36 |
Proposed branch: | lp:~camptocamp/sale-wkfl/7.0-avoid_sale_lines_dropshipping_make_to_order_without_supplierinfos-rde |
Merge into: | lp:~sale-core-editors/sale-wkfl/7.0 |
Diff against target: |
33 lines (+16/-0) 1 file modified
sale_dropshipping/sale.py (+16/-0) |
To merge this branch: | bzr merge lp:~camptocamp/sale-wkfl/7.0-avoid_sale_lines_dropshipping_make_to_order_without_supplierinfos-rde |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Yannick Vaucher @ Camptocamp | code review, no tests | Approve | |
Nicolas Bessi - Camptocamp (community) | code review, no test | Approve | |
Review via email: mp+205623@code.launchpad.net |
Description of the change
Hello,
In a dropshipping context,
this branch allows to avoid to confirm a sale line of type 'make_to_order'
if this line comes from a product without supplierinfos (for the moment, a dropshipping sale line without supplierinfo defined leads to a procurement in exception expecting a supplier defined on the product)
At sales confirmation, a warning message suggests to add supplierinfos on the product form.
Romain
To post a comment you must log in.
LGTM,
Romain can you please tell me if tests are still green?