Sales - Workflow and Organization

Code review comment for lp:~camptocamp/sale-wkfl/7.0-add-sale-default-discount-lep

  1. 7.0-add-sale-default-discount-lep
  2. Merge into 7.0
Revision history for this message
Leonardo Pistone (lepistone) wrote :

Pedro,

I renamed the field as you suggested.

The default in the line works because of the attribute "context" in sale.xml. Thanks to Romain Deheele for showing me that.

I also added two tests, and got a bit frustrated when I realized that the YAML test does not get the same behaviour of manual testing (all is OK when manual testing). More details in the commit message and the yaml file.

A broader discussion we could continue later on the community list is: what are yaml tests supposed to test?

Thanks

Reply

« Back to merge proposal