Sales - Reports

Merge lp:~camptocamp/sale-reports/typo_groups_id-rde into lp:~sale-core-editors/sale-reports/7.0

  1. typo_groups_id-rde
  2. Merge into 7.0
Proposed by Romain Deheele - Camptocamp
Status: Merged
Merged at revision: 26
Proposed branch: lp:~camptocamp/sale-reports/typo_groups_id-rde
Merge into: lp:~sale-core-editors/sale-reports/7.0
Diff against target: 12 lines (+1/-1)
1 file modified
sale_order_webkit/report/sale_order.py (+1/-1)
To merge this branch: bzr merge lp:~camptocamp/sale-reports/typo_groups_id-rde
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no tests Approve
Leonardo Pistone code review Approve
Nicolas Bessi - Camptocamp (community) Approve
Review via email: mp+206874@code.launchpad.net

Description of the change

Hello,

Sorry, my previous commit has introduced a typo error:
on res_users, group field is named groups_id, not group_id.

Romain

To post a comment you must log in.
Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote :

LGTM

review: Approve
Revision history for this message
Leonardo Pistone (lepistone) wrote :

ok!

review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

LGTM

review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sale_order_webkit/report/sale_order.py'
2--- sale_order_webkit/report/sale_order.py 2014-02-17 14:34:44 +0000
3+++ sale_order_webkit/report/sale_order.py 2014-02-18 09:33:51 +0000
4@@ -48,7 +48,7 @@
5 except ValueError:
6 #group named group_discount_per_so_line doesn't exist
7 return False
8- groups = res_users_obj.browse(cr, uid, uid, context=context).group_id
9+ groups = res_users_obj.browse(cr, uid, uid, context=context).groups_id
10 return any(x for x in groups if x.id == group_id)
11
12 def _get_company_vat(self):

Subscribers

People subscribed via source and target branches