Merge lp:~camptocamp/sale-reports/add-domain into lp:~sale-core-editors/sale-reports/7.0

Proposed by Nicolas Bessi - Camptocamp
Status: Superseded
Proposed branch: lp:~camptocamp/sale-reports/add-domain
Merge into: lp:~sale-core-editors/sale-reports/7.0
Diff against target: 28 lines (+5/-3)
2 files modified
sale_order_webkit/__openerp__.py (+1/-1)
sale_order_webkit/sale.py (+4/-2)
To merge this branch: bzr merge lp:~camptocamp/sale-reports/add-domain
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp code review, no test Needs Fixing
Review via email: mp+146073@code.launchpad.net

This proposal has been superseded by a proposal from 2013-02-01.

Description of the change

Add domain on text condition relation

To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM

review: Approve (code review, no test)
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

when you change the data model, please increment the version in __openerp__.py

review: Needs Fixing (code review, no test)
12. By Nicolas Bessi - Camptocamp

[FIX] version number

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sale_order_webkit/__openerp__.py'
2--- sale_order_webkit/__openerp__.py 2013-01-24 10:28:45 +0000
3+++ sale_order_webkit/__openerp__.py 2013-02-01 13:51:22 +0000
4@@ -20,7 +20,7 @@
5 ##############################################################################
6
7 {'name': 'Sales Order Report using Webkit Library',
8- 'version': '1.0.1',
9+ 'version': '1.1.1',
10 'category': 'Reports/Webkit',
11 'description': """
12 Sale order webkit
13
14=== modified file 'sale_order_webkit/sale.py'
15--- sale_order_webkit/sale.py 2013-01-24 14:02:07 +0000
16+++ sale_order_webkit/sale.py 2013-02-01 13:51:22 +0000
17@@ -40,8 +40,10 @@
18 _inherit = "sale.order"
19 _description = 'Sale Order'
20
21- _columns = {'text_condition1': fields.many2one('sale.condition_text', 'Header'),
22- 'text_condition2': fields.many2one('sale.condition_text', 'Footer'),
23+ _columns = {'text_condition1': fields.many2one('sale.condition_text', 'Header',
24+ domain=[('type', '=', 'header')]),
25+ 'text_condition2': fields.many2one('sale.condition_text', 'Footer',
26+ domain=[('type', '=', 'footer')]),
27 'note1': fields.html('Header'),
28 'note2': fields.html('Footer')}
29

Subscribers

People subscribed via source and target branches