Merge lp:~camptocamp/sale-reports/7.0-sync-sale_order_webkit_with_invoice_webkit-20130607 into lp:~sale-core-editors/sale-reports/7.0

Proposed by Yannick Vaucher @ Camptocamp
Status: Merged
Merged at revision: 21
Proposed branch: lp:~camptocamp/sale-reports/7.0-sync-sale_order_webkit_with_invoice_webkit-20130607
Merge into: lp:~sale-core-editors/sale-reports/7.0
Diff against target: 195 lines (+62/-102)
1 file modified
sale_order_webkit/report/sale_order.mako (+62/-102)
To merge this branch: bzr merge lp:~camptocamp/sale-reports/7.0-sync-sale_order_webkit_with_invoice_webkit-20130607
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp code review, test Approve
Guewen Baconnier @ Camptocamp code review, no test Approve
Review via email: mp+168055@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve (code review, no test)
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

works fine

review: Approve (code review, test)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sale_order_webkit/report/sale_order.mako'
2--- sale_order_webkit/report/sale_order.mako 2013-05-22 14:26:07 +0000
3+++ sale_order_webkit/report/sale_order.mako 2013-06-07 13:16:47 +0000
4@@ -8,91 +8,43 @@
5 text-align:center;
6 border-collapse: collapse;
7 }
8-
9+.list_sale_table th {
10+ background-color: #EEEEEE;
11+ border: thin solid #000000;
12+ text-align:center;
13+ font-size:12;
14+ font-weight:bold;
15+ padding-right:3px;
16+ padding-left:3px;
17+}
18 .list_sale_table td {
19+ border-top: thin solid #EEEEEE;
20+ text-align:left;
21+ font-size:12;
22+ padding-right:3px;
23+ padding-left:3px;
24+ padding-top:3px;
25+ padding-bottom:3px;
26+}
27+.list_sale_table thead {
28+ display:table-header-group;
29+}
30+
31+td.formatted_note {
32+ text-align:left;
33+ border-right:thin solid #EEEEEE;
34+ border-left:thin solid #EEEEEE;
35 border-top:thin solid #EEEEEE;
36- text-align:right;
37- font-size:12;
38- padding-right:3px;
39- padding-left:3px;
40- padding-top:3px;
41- padding-bottom:3px;
42-}
43-
44-.list_bank_table {
45- text-align:center;
46- border-collapse: collapse;
47-}
48-
49-.list_bank_table td {
50- text-align:left;
51- font-size:12;
52- padding-right:3px;
53- padding-left:3px;
54- padding-top:3px;
55- padding-bottom:3px;
56-}
57-
58-.list_bank_table th {
59- background-color: #EEEEEE;
60- text-align:left;
61- font-size:12;
62- font-weight:bold;
63- padding-right:3px
64- padding-left:3px
65-}
66-
67-.list_sale_table th {
68- background-color: #EEEEEE;
69- border: thin solid #000000;
70- text-align:center;
71- font-size:12;
72- font-weight:bold;
73- padding-right:3px;
74- padding-left:3px;
75-}
76-
77-.list_table thead {
78- display:table-header-group;
79-}
80-
81-
82-.list_tax_table {
83-}
84-.list_tax_table td {
85- text-align:left;
86- font-size:12;
87-}
88-
89-
90-.list_table thead {
91- display:table-header-group;
92-}
93-
94-
95-.list_total_table {
96- border-collapse: collapse;
97-}
98-
99-.list_total_table td {
100- text-align:right;
101- font-size:12;
102-}
103+ padding-left:10px;
104+ font-size:11;
105+}
106+
107+
108
109 .no_bloc {
110 border-top: thin solid #ffffff ;
111 }
112
113-
114-.list_total_table th {
115- background-color: #F7F7F7;
116- border-collapse: collapse;
117-}
118-
119-tfoot.totals tr:first-child td{
120- padding-top: 15px;
121-}
122-
123 .right_table {
124 right: 4cm;
125 width:"100%";
126@@ -102,14 +54,20 @@
127 font-size:12;
128 }
129
130-.note {
131- text-align:left;
132- font-size:10;
133- border-top:thin solid #ffffff;
134- border-left:thin solid #ffffff;
135- border-right:thin solid #ffffff;
136-}
137-
138+tfoot.totals tr:first-child td{
139+ padding-top: 15px;
140+}
141+
142+
143+td.amount, th.amount {
144+ text-align: right;
145+ white-space: nowrap;
146+}
147+
148+
149+.address .recipient .shipping .invoice {
150+ font-size: 12px;
151+}
152
153 </style>
154 </head>
155@@ -207,22 +165,24 @@
156 </tr>
157 </thead>
158 <tbody>
159- %for line in order.order_line:
160- <tr class="line">
161- <td style="text-align:left; " >${ line.name }</td>
162- <td class="amount" width="7.5%">${ formatLang(line.product_uos and line.product_uos_qty or line.product_uom_qty) }</td>
163- <td style="text-align:center;">${ line.product_uos and line.product_uos.name or line.product_uom.name }</td>
164- <td class="amount" width="8%">${formatLang(line.price_unit)}</td>
165- <td style="font-style:italic; font-size: 10;">${ ', '.join([tax.description or tax.name for tax in line.tax_id]) }</td>
166- <td class="amount" width="10%">${line.discount and formatLang(line.discount, digits=get_digits(dp='Sale Price')) or ''} ${line.discount and '%' or ''}</td>
167- <td class="amount" width="13%">${formatLang(line.price_subtotal, digits=get_digits(dp='Sale Price'))}&nbsp;${order.pricelist_id.currency_id.symbol}</td>
168- </tr>
169- %if line.formatted_note:
170- <tr class="line">
171- <td colspan="7" class="note" style="text-align:left;">${line.formatted_note| n}</td>
172- </tr>
173- %endif
174- %endfor
175+ %for line in order.order_line:
176+ <tr class="line">
177+ <td style="text-align:left; " >${ line.name }</td>
178+ <td class="amount" width="7.5%">${ formatLang(line.product_uos and line.product_uos_qty or line.product_uom_qty) }</td>
179+ <td style="text-align:center;">${ line.product_uos and line.product_uos.name or line.product_uom.name }</td>
180+ <td class="amount" width="8%">${formatLang(line.price_unit)}</td>
181+ <td style="font-style:italic; font-size: 10;">${ ', '.join([tax.description or tax.name for tax in line.tax_id]) }</td>
182+ <td class="amount" width="10%">${line.discount and formatLang(line.discount, digits=get_digits(dp='Sale Price')) or ''} ${line.discount and '%' or ''}</td>
183+ <td class="amount" width="13%">${formatLang(line.price_subtotal, digits=get_digits(dp='Sale Price'))}&nbsp;${order.pricelist_id.currency_id.symbol}</td>
184+ </tr>
185+ %if line.formatted_note:
186+ <tr>
187+ <td class="formatted_note" colspan="7">
188+ ${line.formatted_note| n}
189+ </td>
190+ </tr>
191+ %endif
192+ %endfor
193 </tbody>
194 <tfoot class="totals">
195 <tr>

Subscribers

People subscribed via source and target branches