Merge lp:~camptocamp/sale-financial/6.1-sale_markup-multiple_boms-1174733 into lp:~sale-core-editors/sale-financial/6.1

Proposed by Guewen Baconnier @ Camptocamp
Status: Merged
Approved by: Guewen Baconnier @ Camptocamp
Approved revision: 19
Merged at revision: 19
Proposed branch: lp:~camptocamp/sale-financial/6.1-sale_markup-multiple_boms-1174733
Merge into: lp:~sale-core-editors/sale-financial/6.1
Diff against target: 11 lines (+1/-1)
1 file modified
sale_markup/product_markup.py (+1/-1)
To merge this branch: bzr merge lp:~camptocamp/sale-financial/6.1-sale_markup-multiple_boms-1174733
Reviewer Review Type Date Requested Status
Nicolas Bessi - Camptocamp (community) no test Approve
Review via email: mp+161595@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) :
review: Approve (no test)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

The fix is already there in the branch so I assume it has been corrected in another MP. Put as 'Merged'

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Apologies, you are right Yannick, it is not merged. Thanks for your alertness.

Can I ask a reviewer to merge my MP please?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sale_markup/product_markup.py'
2--- sale_markup/product_markup.py 2012-07-12 13:56:17 +0000
3+++ sale_markup/product_markup.py 2013-04-30 12:35:31 +0000
4@@ -116,7 +116,7 @@
5 bom_obj = self.pool.get('mrp.bom')
6 bom_ids = bom_obj.search(cursor, user, [('product_id','in',ids)])
7 for bom in bom_obj.browse(cursor, user, bom_ids):
8- res = _get_parent_bom(bom)
9+ res += _get_parent_bom(bom)
10 final_bom_ids = list(set(res + bom_ids))
11 return list(set(ids + self._get_product(cursor, user, final_bom_ids, context)))
12

Subscribers

People subscribed via source and target branches

to all changes: