Purchase - Workflow and Organization

Merge lp:~camptocamp/purchase-wkfl/7.0-fix-agreement-trigger-nbi into lp:~purchase-core-editors/purchase-wkfl/7.0

  1. 7.0-fix-agreement-trigger-nbi
  2. Merge into 7.0
Proposed by Nicolas Bessi - Camptocamp
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 28
Merged at revision: 31
Proposed branch: lp:~camptocamp/purchase-wkfl/7.0-fix-agreement-trigger-nbi
Merge into: lp:~purchase-core-editors/purchase-wkfl/7.0
Diff against target: 14 lines (+2/-2)
1 file modified
framework_agreement/model/framework_agreement.py (+2/-2)
To merge this branch: bzr merge lp:~camptocamp/purchase-wkfl/7.0-fix-agreement-trigger-nbi
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no test Approve
Romain Deheele - Camptocamp (community) code review Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+217746@code.launchpad.net

Description of the change

Fix trigger when line is created

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM.

Thanks

review: Approve (code review)
Revision history for this message
Romain Deheele - Camptocamp (romaindeheele) wrote :

LGTM too.

Romain

review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

LGTM

review: Approve (code review, no test)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'framework_agreement/model/framework_agreement.py'
2--- framework_agreement/model/framework_agreement.py 2014-02-05 09:08:33 +0000
3+++ framework_agreement/model/framework_agreement.py 2014-04-30 11:45:25 +0000
4@@ -249,8 +249,8 @@
5 res = set()
6 pol_obj = self.pool.get('purchase.order.line')
7 for row in pol_obj.browse(cr, uid, ids, context=context):
8- if row.framework_agreement_id:
9- res.update([row.framework_agreement_id.id])
10+ if row.order_id.framework_agreement_id:
11+ res.update([row.order_id.framework_agreement_id.id])
12 return res
13
14 _store_tuple = (lambda self, cr, uid, ids, c={}: ids, ['quantity'], 10)

Subscribers

People subscribed via source and target branches